Opened 2 years ago

Last modified 21 months ago

#20285 new defect

can't create valid case 2b3 consens weight calculation

Reported by: pastly Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth weight-calculation
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Even if #20284 is fixed, I still can come up with values that produce a Wed that is too large. Maybe I'm not trying hard enough, but I can't get case 2b3 to execute successfully.

For example, let

M=80
E=20
G=30
D=10
T=M+E+G+D

In case 2b2, Wed = (weight_scale*(D - 2*E + G + M))/(3*D) = 26667. That's bigger than weight_scale. It (and Wmd) trigger case 2b3, which doesn't do anything about a too large Wed and thus networkstatus_check_weights() fails.

I admit I don't know how reasonable the values are that I came up with above. I am writing test cases so #14881 can be closed though, and just about any weird combination should be handled without failing. Right?

I don't know what the correct resolution is, so not patch/branch incoming at this time.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by teor

Cc: mikeperry added
Milestone: Tor: 0.3.0.x-final

comment:2 Changed 2 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: unspecified

Triaged out on December 2016 from 030 to Unspecified.

comment:3 Changed 22 months ago by nickm

Keywords: triage-out-030-201612 removed

comment:4 Changed 21 months ago by nickm

Keywords: tor-dirauth weight-calculation added
Note: See TracTickets for help on using tickets.