Opened 6 months ago

Closed 6 months ago

#20290 closed task (fixed)

Upgrade meek to 0.24

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: meek TorBrowserTeam201610R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by dcf)

Version 0.24 has a fix for #20030, which prevented meek-client-torbrowser from cleaning up is subprocesses when built with Go 1.6 or later.

Here's the diff from the version we're using now. The only substantive changes are those that have to do with #20030.

https://gitweb.torproject.org/pluggable-transports/meek.git/diff/?id=0.24&id2=0.22-18371-3

A patch is forthcoming.

Child Tickets

Attachments (2)

0001-Bug-20290-Upgrade-meek-to-0.24.patch (2.3 KB) - added by dcf 6 months ago.
0001-Bug-20290-Upgrade-meek-to-0.24.2.patch (2.3 KB) - added by dcf 6 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 months ago by dcf

  • Keywords TorBrowserTeam201610R added
  • Status changed from new to needs_review

Here is a patch. I tested a complete build on top of maint-6.0 (currently cb3868eb) and was able to bootstrap meek-amazon on linux and windows. I didn't test mac. I had also applied a commit to upgrade Go to 1.6.3, but I don't think that would affect the results.

comment:2 Changed 6 months ago by dcf

  • Description modified (diff)

comment:3 Changed 6 months ago by dcf

Updated the patch to fix the commit message; #20030 affected Go 1.6 and later, not Go 1.5 and later.

comment:4 Changed 6 months ago by gk

  • Resolution set to fixed
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.