Opened 22 months ago

Closed 4 months ago

#20301 closed defect (duplicate)

Bumping the compiler version to 6.2.0 breaks 64bit Tor Browser builds

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Blocker Keywords: GeorgKoppen201610, tbb-rbm, boklm201803, TorBrowserTeam201803R
Cc: Actual Points:
Parent ID: #25304 Points:
Reviewer: Sponsor:

Description

After bumping the GCC version to 6.2.0 due to #13893 building GCC 6.2.0 is busted for 64bits in our gitian setup:

/usr/bin/ld.bfd.real: gcov.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC

Child Tickets

Change History (17)

comment:1 Changed 22 months ago by gk

This works fine with hardening-wrapper settings as we have them in Gitian on a Debian testing machine. Additionally, setting DEB_BUILD_HARDENING_PIE=0 for the GCC step in our Gitian build would help as well.

comment:2 Changed 22 months ago by gk

The Wheezy compiler is too old for it (generally 4.x).

comment:3 Changed 21 months ago by gk

Keywords: TorBrowserTeam201610R GeorgKoppen201610 added; TorBrowserTeam201610 removed
Status: newneeds_review

Okay, I bisected the problem (PIE enforcement breaks the compiler) and pushed a fix for review to bug_20301 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20301&id=dfa3403825fc315168df3295f6062f5979b0a8a0) in my public repo.

Last edited 21 months ago by gk (previous) (diff)

comment:4 Changed 21 months ago by gk

Keywords: TorBrowserTeam201610 added; TorBrowserTeam201610R removed
Status: needs_reviewnew

Taking off the review queue as GCC 6 seems to be too unstable to use right now. See #20381 for further details.

comment:5 Changed 11 months ago by gk

Keywords: tbb-rbm added; tbb-gitian removed

Moving over to rbm

comment:6 Changed 5 months ago by boklm

Keywords: boklm201802 added

comment:7 Changed 5 months ago by boklm

Keywords: TorBrowserTeam201802 added; TorBrowserTeam201610 removed

comment:8 Changed 5 months ago by tom

Any reason you went with 6.2? I'm using 6.4 (for 32 bit) in TaskCluster.

comment:9 in reply to:  8 ; Changed 5 months ago by boklm

Replying to tom:

Any reason you went with 6.2? I'm using 6.4 (for 32 bit) in TaskCluster.

I think when this ticket was opened (October 2016), 6.2 was the last version. We should probably use 6.4 now.

comment:10 in reply to:  9 Changed 5 months ago by cypherpunks

Replying to boklm:

I think when this ticket was opened (October 2016), 6.2 was the last version. We should probably use 6.4 now.

7.3 now.

comment:11 in reply to:  9 Changed 5 months ago by gk

Replying to boklm:

Replying to tom:

Any reason you went with 6.2? I'm using 6.4 (for 32 bit) in TaskCluster.

I think when this ticket was opened (October 2016), 6.2 was the last version. We should probably use 6.4 now.

Yes, exactly.

comment:12 Changed 5 months ago by boklm

Parent ID: #25304

comment:13 Changed 4 months ago by boklm

Keywords: boklm201803 added; boklm201802 removed

boklm201802 -> boklm201803

comment:14 Changed 4 months ago by gk

Keywords: TorBrowserTeam201803 added; TorBrowserTeam201802 removed

Adding to our March plate.

comment:15 in reply to:  3 ; Changed 4 months ago by boklm

Keywords: TorBrowserTeam201803R added; TorBrowserTeam201803 removed
Status: newneeds_review

Replying to gk:

Okay, I bisected the problem (PIE enforcement breaks the compiler) and pushed a fix for review to bug_20301 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20301&id=dfa3403825fc315168df3295f6062f5979b0a8a0) in my public repo.

I applied the same fix, using the same comment, to tor-browser-build in branch bug_20301:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20301&id=4e57f8a0780fd9ed9633dc7d2391bf908b74e337

comment:16 in reply to:  15 Changed 4 months ago by gk

Replying to boklm:

Replying to gk:

Okay, I bisected the problem (PIE enforcement breaks the compiler) and pushed a fix for review to bug_20301 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20301&id=dfa3403825fc315168df3295f6062f5979b0a8a0) in my public repo.

I applied the same fix, using the same comment, to tor-browser-build in branch bug_20301:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20301&id=4e57f8a0780fd9ed9633dc7d2391bf908b74e337

The comment looks good to me. Although, we won't update GCC to 6.2.0 anymore. Thus, the commit message is wrong. I think we should just close this bug an apply the comment about disabling PIE in the upcoming patch for #25304.

comment:17 Changed 4 months ago by boklm

Resolution: duplicate
Status: needs_reviewclosed

Ok, I think it makes sense to do it in the patch for #25304.

Note: See TracTickets for help on using tickets.