Opened 15 months ago

Last modified 3 months ago

#20301 new defect

Bumping the compiler version to 6.2.0 breaks 64bit Tor Browser builds

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Blocker Keywords: GeorgKoppen201610, TorBrowserTeam201610, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After bumping the GCC version to 6.2.0 due to #13893 building GCC 6.2.0 is busted for 64bits in our gitian setup:

/usr/bin/ld.bfd.real: gcov.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC

Child Tickets

Change History (5)

comment:1 Changed 14 months ago by gk

This works fine with hardening-wrapper settings as we have them in Gitian on a Debian testing machine. Additionally, setting DEB_BUILD_HARDENING_PIE=0 for the GCC step in our Gitian build would help as well.

comment:2 Changed 14 months ago by gk

The Wheezy compiler is too old for it (generally 4.x).

comment:3 Changed 14 months ago by gk

Keywords: TorBrowserTeam201610R GeorgKoppen201610 added; TorBrowserTeam201610 removed
Status: newneeds_review

Okay, I bisected the problem (PIE enforcement breaks the compiler) and pushed a fix for review to bug_20301 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20301&id=dfa3403825fc315168df3295f6062f5979b0a8a0) in my public repo.

Last edited 14 months ago by gk (previous) (diff)

comment:4 Changed 14 months ago by gk

Keywords: TorBrowserTeam201610 added; TorBrowserTeam201610R removed
Status: needs_reviewnew

Taking off the review queue as GCC 6 seems to be too unstable to use right now. See #20381 for further details.

comment:5 Changed 3 months ago by gk

Keywords: tbb-rbm added; tbb-gitian removed

Moving over to rbm

Note: See TracTickets for help on using tickets.