Opened 3 years ago

Last modified 21 months ago

#20325 assigned enhancement

Perform available space check using the partition recent is located on

Reported by: iwakeh Owned by: metrics-team
Priority: Low Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: metrics-help, metrics-2018
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by iwakeh)

Currently, the root path of the configured 'recent' directory is used when measuring the available space.

This might not make sense in situations when partitions are mounted elsewhere.
For example:

/dev/sda1 on /      (just the os)
/dev/sdb1 on /data  (here the 'recent' folder resides somewhere)

In this case sda1 might be small and sdb1 could be the huge data partition. Thus, the measurement of free space for / is useless.

Suggestion:
(cf. comments)
Last resort: add CheckSpacePath property and default to the root of the recent path in case it doesn't exist.

Child Tickets

Change History (11)

comment:1 Changed 3 years ago by iwakeh

Another option is to implement finding the actual partition 'recent' is located on and check available space on that.
Might be better.

comment:2 Changed 3 years ago by karsten

If there's no easy way to find the actual partition of the recent/ directly, couldn't we check available space directly in the recent/ directory? And if that doesn't exist, which we can check, check its parent directory? And if that doesn't exist, go further up until we arrive at the root?

Adding a config option seems like we're asking operators to solve a problem we could as well solve in the code. I'd say let's keep that as last resort.

comment:3 Changed 3 years ago by iwakeh

Description: modified (diff)
Owner: set to iwakeh
Status: newaccepted
Summary: make data directory for available space check configurableperform available space check using the partition recent is located on

Yes.
Edited title and text a little to reflect these ideas.

comment:4 Changed 3 years ago by iwakeh

Keywords: metrics-help added

Suited for getting acquainted with ColleTor build environment.

comment:5 Changed 2 years ago by iwakeh

Cc: iwakeh added

Adding myself to cc to make trac mail updates.

comment:6 Changed 2 years ago by karsten

Milestone: CollecTor 1.2.0

We're planning to put out 1.2.0 in 5 days from now, and including this ticket in that release seems too ambitious. Removing from milestone for now.

comment:7 Changed 2 years ago by karsten

Summary: perform available space check using the partition recent is located onPerform available space check using the partition recent is located on

Capitalize summary.

comment:8 Changed 2 years ago by karsten

Keywords: metrics-2018 added

comment:9 Changed 2 years ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:10 Changed 22 months ago by iwakeh

Keywords: metrics-2018 added; metrics-2017 removed

Will be completed in 2018.

comment:11 Changed 21 months ago by iwakeh

Owner: changed from iwakeh to metrics-team
Status: acceptedassigned

Move to metrics-team as these are not worked on by me during the next week.

Note: See TracTickets for help on using tickets.