Opened 9 months ago

Closed 2 months ago

#20341 closed defect (implemented)

torrc man page missing components for Bridge line

Reported by: stefanib Owned by: catalyst
Priority: Low Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: torrc, manual, page, tor-03-unspecified-201612
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

The man page for torrc Bridge currently has an entry:
Bridge [transport] IP:ORPort [fingerprint]

an example line i was just given had a bit more than this:

Bridge [transport] IP:ORPort [fp] [cert=...] ] iat-mode=0

perhaps a description of iat-mode and its values would be helpful? and extend the config line?

Child Tickets

Change History (16)

comment:1 Changed 9 months ago by arma

  • Component changed from - Select a component to Core Tor/Tor
  • Milestone set to Tor: unspecified

comment:2 Changed 9 months ago by yawning

  • Priority changed from Medium to Low

The extra args including iat-mode are specific to obfs4 and should not be part of the tor man page, especially since it's an entirely separate piece of software.

That said, the documentation for the bridge line could clarify that, transports can add arbitrary things to the bridge line.

comment:3 Changed 9 months ago by nickm

That said, the documentation for the bridge line could clarify that, transports can add arbitrary things to the bridge line.

+1 on this.

comment:4 Changed 8 months ago by dgoulet

  • Milestone changed from Tor: unspecified to Tor: 0.2.???
  • Points set to 0.1

comment:5 Changed 8 months ago by teor

  • Milestone changed from Tor: 0.2.??? to Tor: 0.3.???

Milestone renamed

comment:6 Changed 6 months ago by nickm

  • Keywords tor-03-unspecified-201612 added
  • Milestone changed from Tor: 0.3.??? to Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 2 months ago by arma

  • Milestone changed from Tor: unspecified to Tor: 0.3.2.x-final

Moving up its milestone so it doesn't get forgotten.

(catalyst just bumped into the same bug.)

comment:8 Changed 2 months ago by nickm

(I'd take a patch for this in 0.3.1 if someone writes one in time)

comment:9 Changed 2 months ago by catalyst

  • Owner set to catalyst
  • Status changed from new to assigned

comment:10 Changed 2 months ago by catalyst

  • Status changed from assigned to needs_review

comment:11 Changed 2 months ago by nickm

  • Milestone changed from Tor: 0.3.2.x-final to Tor: 0.3.1.x-final

comment:12 Changed 2 months ago by nickm

LGTM; just needs a changes file. (And maybe also an explanation that you'll need to look at the transport's documentation to see what kind of arguments it supports?)

comment:13 Changed 2 months ago by catalyst

Updated with changes file and your suggested addition.

comment:14 Changed 2 months ago by catalyst

This support looks like it was added to config.c in 757b03aacbf7051194bbe9faa2bfcc59e4cc3392 which is around tor-0.2.4.10-alpha?

comment:15 Changed 2 months ago by catalyst

Updated again, adding bug number and first-appeared details in the changes file.

comment:16 Changed 2 months ago by nickm

  • Resolution set to implemented
  • Status changed from needs_review to closed

lgtm; update looks good. Merged!

Note: See TracTickets for help on using tickets.