Opened 3 years ago

Closed 3 years ago

#20342 closed enhancement (fixed)

Add tor-gencert.exe to tor expert bundle

Reported by: teor Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: testing, tbb-gitian, GeorgKoppen201610, TorBrowserTeam201610R
Cc: gk, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by teor)

At the recent tor developer meeting, a volunteer tried to get chutney working on Windows, but tor-gencert.exe wasn't in the tor expert bundle.

If we want people to test Tor on Windows, we need to add at least tor-gencert.exe to the windows expert ~and nightly~ bundles. ~There might be other binaries we want to add as well.~

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by gk

Cc: gk added

comment:2 Changed 3 years ago by asn

Hm, should this be a Core Tor ticket or a Tor Browser ticket?

comment:3 in reply to:  2 Changed 3 years ago by teor

Replying to asn:

Hm, should this be a Core Tor ticket or a Tor Browser ticket?

I don't know.
Who builds the tor nightlies? Do we have one for Windows?
Who builds the tor expert bundle?

comment:4 Changed 3 years ago by arma

Cc: boklm added

The Tor Browser build process generates the Windows expert bundles.

teor: when you say nightlies, which ones do you mean?

...So I guess that means this should be a Tor Browser ticket, to the attention of boklm.

comment:5 in reply to:  4 Changed 3 years ago by teor

Component: Core Tor/TorApplications/Tor Browser
Description: modified (diff)
Keywords: 029-proposed removed
Milestone: Tor: 0.2.???
Owner: set to tbb-team
Points: 0.5
Priority: HighMedium
Severity: MajorNormal
Summary: Add tor-gencert.exe to tor expert bundle and tor nightliesAdd tor-gencert.exe to tor expert bundle
Type: defectenhancement

Replying to arma:

The Tor Browser build process generates the Windows expert bundles.

Ok. Switched this ticket over to TBB.

I wonder if it makes sense to add tor-gencert to all the tor browser bundles. Probably not. The likely benefit is negligible, versus the extra download cost.

...So I guess that means this should be a Tor Browser ticket, to the attention of boklm.

teor: when you say nightlies, which ones do you mean?

It turns out that the debian experimental / nightly / alpha builds already have tor-gencert, and chutney finds that OK. If we want to do that for other platforms, I've split it off into #20346.

comment:6 Changed 3 years ago by gk

Keywords: tbb-gitian GeorgKoppen201610 TorBrowserTeam201610R added
Status: newneeds_review

comment:7 in reply to:  6 Changed 3 years ago by boklm

Replying to gk:

bug_20342 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20342&id=9d1f518b29b254bbfcd15fc69f7d149687eb49c8) in my public tor-browser-bundle repo has a fix for that.

The patch looks good to me.

comment:8 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit 9d1f518b29b254bbfcd15fc69f7d149687eb49c8 on master and 43cf1a1ce71a143a29819d149fa0da44cf7c8dc7 on maint-6.0.

Note: See TracTickets for help on using tickets.