Opened 4 years ago

Closed 11 months ago

#20351 closed enhancement (wontfix)

Turn the updateindex module into a function that runs after each module run

Reported by: iwakeh Owned by: metrics-team
Priority: Medium Milestone: CollecTor 1.7.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords: metrics-2018
Cc: metrics-team Actual Points:
Parent ID: #20518 Points:
Reviewer: Sponsor:

Description

Once, #20350 is in place. updateindex can be plainly added as a function that runs after each module run.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by iwakeh

Parent ID: #20518

comment:2 Changed 3 years ago by karsten

Summary: updateindex should become a functionTurn the updateindex module into a function that runs after each module run

Attempt to make the summary a bit clearer.

comment:3 Changed 3 years ago by karsten

Keywords: metrics-2018 added

comment:4 Changed 3 years ago by karsten

Owner: set to metrics-team
Status: newassigned

comment:5 Changed 3 years ago by iwakeh

Owner: changed from metrics-team to iwakeh
Status: assignedaccepted

comment:6 Changed 3 years ago by irl

Cc: metrics-team added

Adding metrics-team to cc

comment:7 Changed 3 years ago by iwakeh

Status: acceptedneeds_review

Please review this patch branch. I chose warn-level for index-update failures as these are attempted after each module run.

(review is not urgent as this should be deployed together with #20350)

comment:8 Changed 3 years ago by iwakeh

Milestone: CollecTor 1.6.0

comment:9 Changed 3 years ago by karsten

Status: needs_reviewneeds_information

I just did a quick review of commit 7aa8984, and I think this can work. I did not try it out, though. We'll indeed have to do #20350 first before merging this. Not sure if this is the right thing to do, but I'm setting this ticket to needs_information until #20350 is resolved. Thanks!

comment:10 Changed 2 years ago by iwakeh

Owner: changed from iwakeh to metrics-team
Status: needs_informationassigned

Re-assigning to metrics-team as the patch is provided as well as reviewed and the ticket is waiting for the implementation of #20350.

comment:11 Changed 2 years ago by iwakeh

Milestone: CollecTor 1.6.0CollecTor 1.7.0

Moved to new milestone.

comment:12 Changed 11 months ago by karsten

Resolution: wontfix
Status: assignedclosed

With #31204 being implemented this ticket is no longer relevant. We need to check every two minutes for changed files and for completed index tasks. We shouldn't mess with this schedule by starting another check at the end of each module runs. It takes at least two minutes anyway for new files to show up in index.json. We can simply close this ticket as something we won't implement. Doing so.

Note: See TracTickets for help on using tickets.