Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20373 closed defect (fixed)

Privacy and Security Settings window opens twice

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Minor Keywords: tbb-usability, TorBrowserTeam201610R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If the user chooses "Privacy and Security Settings" from the torbutton menu 4 times in a row, here's what happens:

  1. P&S dialog opens
  2. nothing happens
  3. Another P&S dialog opens (now two are open simultaneously)
  4. nothing happens

I think a better behavior would be:

  1. Dialog opens
  2. Dialog gets focus
  3. Dialog gets focus
  4. Dialog gets focus

If the user closes the dialog, of course choosing the menu again should result in opening the window again.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by arthuredelstein

comment:2 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201610R added
Status: newneeds_review

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me and fixed with commit 52fbcbfa9df65d56dce5b1654c4d56012b3ff6a9 on torbutton master.

comment:4 Changed 3 years ago by mcs

I know this is a late comment (and the patch looks OK to me), but rather than tracking open windows inside Torbutton I would have used nsIWindowMediator.getMostRecentWindow() to find the dialog if it is open (we would need to add a unique type attribute to the dialog XUL). Or maybe there is a reason why that approach would not work in this situation.

comment:5 in reply to:  4 ; Changed 3 years ago by arthuredelstein

Replying to mcs:

I know this is a late comment (and the patch looks OK to me), but rather than tracking open windows inside Torbutton I would have used nsIWindowMediator.getMostRecentWindow() to find the dialog if it is open (we would need to add a unique type attribute to the dialog XUL). Or maybe there is a reason why that approach would not work in this situation.

I think you're right that this approach would likely work, too. I hadn't thought of using it. If you or gk would prefer I can add a follow-on patch.

comment:6 in reply to:  5 Changed 3 years ago by mcs

Replying to arthuredelstein:

I think you're right that this approach would likely work, too. I hadn't thought of using it. If you or gk would prefer I can add a follow-on patch.

For me this is not essential, especially given the other tasks we all have on our plates.

Note: See TracTickets for help on using tickets.