Opened 2 years ago
Closed 2 years ago
#20374 closed defect (fixed)
Atlas should warn its users if Onionoo serves outdated data
Reported by: | karsten | Owned by: | irl |
---|---|---|---|
Priority: | High | Milestone: | |
Component: | Metrics/Relay Search | Version: | |
Severity: | Normal | Keywords: | |
Cc: | Actual Points: | ||
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
The updater of the Onionoo mirror broke in the last week of September, yet Atlas showed its results as if nothing had happened. Atlas should really look at the date given in the Onionoo documents header and at least display a warning if that date is older than 12 or 24 hours.
Child Tickets
Change History (6)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
Status: | new → accepted |
---|
comment:3 Changed 2 years ago by
Owner: | changed from irl to RaBe |
---|
comment:4 Changed 2 years ago by
Owner: | changed from RaBe to irl |
---|---|
Status: | accepted → assigned |
I added a check for the LastModified-HTTP-Header and show a warning message if it's older than 24 hours:
https://github.com/RaphaelBergmann/atlas/commit/258159fc84d5201869c07b0b42088998e8b38e95
(You can try it by changing Line 271 @ js/helpers.js to 0 hours instead of 24...)
comment:5 Changed 2 years ago by
Status: | assigned → needs_review |
---|
comment:6 Changed 2 years ago by
Resolution: | → fixed |
---|---|
Status: | needs_review → closed |
Thanks for your work on this, merged. (:
Note: See
TracTickets for help on using
tickets.
This should also apply to Compass as well. 24 hours age limit should be ok.