Opened 3 years ago

Closed 20 months ago

#20375 closed enhancement (fixed)

warn users when entering fullscreen

Reported by: fem Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, tbb-fingerprinting, tbb-torbutton, TorBrowserTeam201708R, tbb-backported
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor Browser will now warn users when they change the window size, but not when they enter fullscreen. Until the implementation of #12977 I think having a similar warning to the window size changes would help a lot. The two warnings could be generalised and used for both (but maybe there are translation issues with this)

Child Tickets

Change History (14)

comment:1 Changed 21 months ago by gk

Keywords: TorBrowserTeam201708R added
Status: newneeds_review

comment:2 Changed 21 months ago by gk

Cc: arthuredelstein added

comment:3 Changed 21 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for backporting to the stable series.

comment:4 in reply to:  3 Changed 21 months ago by arthuredelstein

Replying to gk:

Looks good. Applied to master (commit f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for backporting to the stable series.

I think backporting would be a good idea, because currently Tor Browser does not show a warning at all when the user clicks on the maximize window button in the title bar. That's because macOS (at least in the latest versions) seems to always use window.STATE_FULLSCREEN instead of window.STATE_MAXIMIZE.

comment:5 Changed 21 months ago by arthuredelstein

Resolution: fixed
Status: closedreopened

comment:6 Changed 21 months ago by arthuredelstein

Status: reopenedneeds_review

comment:7 Changed 21 months ago by gk

Status: needs_reviewneeds_information

What (new) code is here for review? It landed already on master.

comment:8 Changed 21 months ago by arthuredelstein

Sorry -- no new code. I just thought we should somehow mark this ticket as a candidate for backporting. Is there a preferred way to do this?

comment:9 Changed 21 months ago by gk

Resolution: fixed
Status: needs_informationclosed

I am not sure yet. What I am currently doing is:

1) If I am sure it should go into the next stable and next alpha I apply the patch for both master and the proper maint- branch.

2) Once a new stable release is about to get built I
a) go over the things that are in the alpha but not stable series and decide whether they baked enough to get included into the stable or not.
b) think about whether the things that are scheduled for the next alpha but not stable (i.e. on master but no maint- branch) should be alpha only or whether I got convinced that they provide so much benefit that they should go into the stable directly as well.

comment:10 Changed 21 months ago by cypherpunks

How about fake windowed fullscreen?

comment:11 Changed 21 months ago by gk

Keywords: tbb-backport added

comment:12 Changed 20 months ago by gk

Keywords: tbb-backported added; tbb-backport removed

Picking this up for 1.9.7.7 (commit d68d2b68366af9456adf8c152e127ec5c10344c5).

comment:13 Changed 20 months ago by Dbryrtfbcbhgf

Resolution: fixed
Status: closedreopened

Rhe warning popup is Immediately dismissed when I lick on a link and a new page loads.
example,
open tor browser and then right as it pops up click on "Test tor network settings" and then maximize tor, the page takes around 5 seconds to load so the full screen warning pops up and then is Immediately dismissed when the page loads.

comment:14 in reply to:  13 Changed 20 months ago by cypherpunks

Resolution: fixed
Status: reopenedclosed

Replying to Dbryrtfbcbhgf:

Rhe warning popup is Immediately dismissed when I lick on a link and a new page loads.

:-))))))) Don't lick the links :-)))))))

example,
open tor browser and then right as it pops up click on "Test tor network settings" and then maximize tor, the page takes around 5 seconds to load so the full screen warning pops up and then is Immediately dismissed when the page loads.

It warned you, but you loaded a new page.

Note: See TracTickets for help on using tickets.