warn users when entering fullscreen

Tor Browser will now warn users when they change the window size, but not when they enter fullscreen. Until the implementation of #12977 (moved) I think having a similar warning to the window size changes would help a lot. The two warnings could be generalised and used for both (but maybe there are translation issues with this)

Trac:
Username: fem

added TorBrowserTeam201708R component::applications/tor browser owner::tbb-team priority::high reporter::fem resolution::fixed severity::normal status::closed tbb-backported tbb-fingerprinting tbb-torbutton tbb-usability type::enhancement labels

See: https://github.com/arthuredelstein/torbutton/commit/d2e35dd0177e7314fb223ee0e05b1c33e3119352 for a patch up for review.

Trac:
Keywords: N/A deleted, TorBrowserTeam201708R added
Status: new to needs_review

Trac:
Cc: N/A to arthuredelstein

Looks good. Applied to master (commit f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for backporting to the stable series.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Replying to gk:

Looks good. Applied to master (commit f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for backporting to the stable series.

I think backporting would be a good idea, because currently Tor Browser does not show a warning at all when the user clicks on the maximize window button in the title bar. That's because macOS (at least in the latest versions) seems to always use window.STATE_FULLSCREEN instead of window.STATE_MAXIMIZE.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Status: reopened to needs_review

What (new) code is here for review? It landed already on master.

Trac:
Status: needs_review to needs_information

Sorry -- no new code. I just thought we should somehow mark this ticket as a candidate for backporting. Is there a preferred way to do this?

I am not sure yet. What I am currently doing is:

1. If I am sure it should go into the next stable and next alpha I apply the patch for both master and the proper maint- branch.

2. Once a new stable release is about to get built I a) go over the things that are in the alpha but not stable series and decide whether they baked enough to get included into the stable or not. b) think about whether the things that are scheduled for the next alpha but not stable (i.e. on master but no maint- branch) should be alpha only or whether I got convinced that they provide so much benefit that they should go into the stable directly as well.

Trac:
Resolution: N/A to fixed
Status: needs_information to closed

How about fake windowed fullscreen?

Trac:
Keywords: N/A deleted, tbb-backport added

Picking this up for 1.9.7.7 (commit d68d2b68366af9456adf8c152e127ec5c10344c5).

Trac:
Keywords: tbb-backport deleted, tbb-backported added

Rhe warning popup is Immediately dismissed when I lick on a link and a new page loads. example, open tor browser and then right as it pops up click on "Test tor network settings" and then maximize tor, the page takes around 5 seconds to load so the full screen warning pops up and then is Immediately dismissed when the page loads.

Trac:
Username: Dbryrtfbcbhgf
Status: closed to reopened
Resolution: fixed to N/A

Replying to Dbryrtfbcbhgf:

Rhe warning popup is Immediately dismissed when I lick on a link and a new page loads. :-))))))) Don't lick the links :-))))))) example, open tor browser and then right as it pops up click on "Test tor network settings" and then maximize tor, the page takes around 5 seconds to load so the full screen warning pops up and then is Immediately dismissed when the page loads. It warned you, but you loaded a new page.

Trac:
Resolution: N/A to fixed
Status: reopened to closed

closed

mentioned in issue #22989 (moved)

moved to tpo/applications/tor-browser#20375 (closed)