Opened 3 years ago

Closed 3 years ago

#20394 closed defect (fixed)

Remove dead code in torbutton

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-code-cleanup, TorBrowserTeam201610R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Some code in torbutton is explicitly annotated as obsolete ("Bug 1506 P0"). Might as well remove it if it is truly obsolete.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by arthuredelstein

Status: newneeds_review

In this patch I deleted an obsolete contents.rdf file, and two functions that are not used anywhere. The torbutton_new_tab function *does* appear to be in use, so I removed its P0 annotation.

https://github.com/arthuredelstein/torbutton/commit/20394

comment:2 Changed 3 years ago by gk

Keywords: TorBrowserTeam201610 added; TorBrowserTeam201610R removed
Status: needs_reviewneeds_revision

Two things:

1) What about the contents.rdf file in chrome/skin?
2) There is not P0 anymore in torbutton.js after your clean-up, right? We should change comment on the first line accordingly then: s/P0/P1/

comment:3 Changed 3 years ago by gk

Oh, and a bug number in your commit message would be good. (although I am usually fixing this if it's missing ;) )

comment:4 in reply to:  3 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201610R added; TorBrowserTeam201610 removed
Status: needs_revisionneeds_review

Replying to gk, comment 2:

Two things:

1) What about the contents.rdf file in chrome/skin?
2) There is not P0 anymore in torbutton.js after your clean-up, right? We should change comment on the first line accordingly then: s/P0/P1/

Replying to gk, comment 3:

Oh, and a bug number in your commit message would be good. (although I am usually fixing this if it's missing ;) )

All good points. Sorry for forgetting the bug number! Here is the branch with fixes:
https://github.com/arthuredelstein/torbutton/commit/20394+1

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Cherry-picked to master, thanks (commit 70e5f3b26c7e4d22158b02757681170ac0daadf5).

Note: See TracTickets for help on using tickets.