Opened 3 years ago

Closed 3 years ago

#20429 closed defect (fixed)

TOR_SKIP_LAUNCH=1: progress window stays open

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: tbb-usability, TorBrowserTeam201610R
Cc: brade, gk, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you run tor separately and use TOR_SKIP_LAUNCH=1 to start Tor Browser, Tor Launcher opens its progress window after you make changes via Tor Network Settings window. The progress window never makes any progress, and if you cancel it tor is left in the DisableNetwork=1 state.

Kathy and I do not think the progress window should open in this situation. It looks like the code is confused by checking to see whether the bootstrap process has finished (in this case Tor Launcher thinks it has not finished, but really it has no idea).

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by mcs

Keywords: tbb-usability TorBrowserTeam201610R added
Status: newneeds_review

comment:2 Changed 3 years ago by mcs

Cc: gk arthuredelstein added

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Applied to master, maint-0.2.10 and maint-0.2.9 (commits c12d56470b7164c33b3cb2e48a90dc65151a9a26, 8aa78d3a78bbabe01759b63d837b09acdf53be42 and 2014143e0081170267a34e3a102878999dee6a29)

Note: See TracTickets for help on using tickets.