Opened 3 years ago

Last modified 22 months ago

#20475 new defect

Setting bwscanner min_exits to 1 causes no exits to be selected

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #4269 Points:
Reviewer: Sponsor:

Description

It looks like there's an off-by-one error in the code that handles this minimun:

diff --git a/NetworkScanners/BwAuthority/bwauthority_child.py b/NetworkScanners/BwAuthority/bwauthority_child.py
index a36728f..248c6d0 100755
--- a/NetworkScanners/BwAuthority/bwauthority_child.py
+++ b/NetworkScanners/BwAuthority/bwauthority_child.py
@@ -67,7 +68,7 @@ __selmgr = PathSupport.SelectionManager(
      use_guards=False,
      exit_ports=[443],
      order_by_ratio=True, # XXX: may be a poor idea for PID control?
-      min_exits=10)
+      min_exits=1)

# exit code to indicate scan completion
# make sure to update this in bwauthority.py as well

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by teor

Parent ID: #4269

comment:2 Changed 2 years ago by teor

Priorities and Severities in torflow are meaningless, setting them all to Medium/Normal.

comment:3 Changed 2 years ago by teor

Owner: aagbsn deleted
Status: newassigned

aagbsn was the default owner, unassigning

comment:4 Changed 22 months ago by teor

Status: assignednew

Mark all tickets that are assigned to nobody as "new".

Note: See TracTickets for help on using tickets.