Opened 3 years ago

Closed 3 years ago

#20476 closed defect (fixed)

stem exit policy tests fail on master

Reported by: teor Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The following stem tests fail on master:

test_all_private_policy                                      [FAILURE]
...
test_mixed_private_policy                                    [FAILURE]

I think it's likely this is due to ExitPolicyRejectLocalInterfaces in #18456.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by teor

The detailed logs are:

======================================================================
FAIL: test_all_private_policy
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/twilsonb/tor/stem/test/unit/exit_policy/policy.py", line 129, in test_all_private_policy
    self.assertTrue(rule.is_private())
AssertionError: False is not true

======================================================================
FAIL: test_mixed_private_policy
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/twilsonb/tor/stem/test/unit/exit_policy/policy.py", line 151, in test_mixed_private_policy
    self.assertTrue(rule.is_accept != rule.is_private())  # only reject rules are the private ones
AssertionError: False is not true

----------------------------------------------------------------------

comment:2 Changed 3 years ago by atagar

Resolution: fixed
Status: newclosed

Thanks teor! Actually, unit tests are Stem testing itself (tor changes don't impact them). The integ tests are what exercise tor.

Took a little head scratching but found the issue. Thanks for the catch!

https://gitweb.torproject.org/stem.git/commit/?id=3cf6949

Note: See TracTickets for help on using tickets.