Opened 3 years ago

Closed 3 years ago

#20487 closed enhancement (implemented)

Should HiddenServiceNonAnonymousMode change default SocksPort to 0?

Reported by: teor Owned by:
Priority: Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: single-onion, tor-hs, doc
Cc: pastly Actual Points:
Parent ID: Points: 0.5
Reviewer: teor Sponsor:

Description

If a user enables single onion services using:

HiddenServiceSingleHopMode 1
HiddenServiceNonAnonymousMode 1

The immediately see:

Oct 28 13:28:46.087 [warn] Failed to parse/validate config: HiddenServiceNonAnonymousMode is incompatible with using Tor as an anonymous client. Please set Socks/Trans/NATD/DNSPort to 0, or HiddenServiceNonAnonymousMode to 0, or use the non-anonymous Tor2webMode.

I think it would be better if we automatically disabled the socks port in this case.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by teor

Cc: pastly added

Based on feedback from pastly on http://bh2lpa5qyawryvk2.onion/

comment:2 Changed 3 years ago by teor

Priority: MediumLow
Severity: NormalMinor

I'm not sure if we should fix this.

It could confuse operators to suddenly have their SocksPort disappear. It could be better to make them specifically set it to 0.

comment:3 Changed 3 years ago by nickm

It could confuse operators to suddenly have their SocksPort disappear. It could be better to make them specifically set it to 0.

I agree, though it might be good to add a note to the manpage entry.

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.2.9.x-final

Since it's a documentation issue, it can be in 0.2.9

comment:5 Changed 3 years ago by nickm

Status: newneeds_review

How's branch bug20487_029 in my public repository?

comment:6 Changed 3 years ago by teor

Keywords: doc added
Reviewer: teor
Status: needs_reviewmerge_ready

Looks good, nice simple doc change.

comment:7 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

okay; merging!

Note: See TracTickets for help on using tickets.