Opened 3 years ago

Closed 2 years ago

#20488 closed defect (fixed)

Nickname registration message is confusing

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, tor-client log-message
Cc: toralf Actual Points: 0.1
Parent ID: #12898 Points: 0.2
Reviewer: Sponsor:


toralf says:

wrt to this syslog massage : "You specified a server "zwiebeltoralf" by name, but the directory authorities do not have any key registered for this nickname"    - how can I register my nickname ?

We should change this message to be clearer, particularly because we don't use the Named/Unnamed flags any more.

We could just say "don't have any relay for this nickname".

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by arma


(We did rip out the rest of the Named code, right?)

(And, are there other log messages that are from back when we had the Named flag?)

comment:2 Changed 3 years ago by nickm

We ripped out a lot of the Named code; there is still a bunch around. I'd love to see somebody pick up the tickets for that

comment:3 Changed 3 years ago by Sebastian

I actually think that the only thing that was missing was stem tests to raise coverage above what it was previoulsy or something, I don't recall anymore. I will eventually pick it up, but not soon.

comment:4 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:5 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 2 years ago by nickm

Keywords: tor-client log-message added
Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Owner: set to nickm
Status: newassigned

comment:8 Changed 2 years ago by nickm

Actual Points: 0.1
Status: assignedneeds_review

bug20488_029 has a fix here.

comment:9 Changed 2 years ago by arma

Parent ID: #12898

comment:10 Changed 2 years ago by arma

Status: needs_reviewmerge_ready

Patch looks good to me!

(It changes one instance of 'server' to 'relay' but leaves the other one alone. But that's ok if you meant to do it.)

comment:11 Changed 2 years ago by cypherpunks

Also a sentence in the changes file reads awkwardly. I suggest removing going.

comment:12 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

IIUC "a going concern" is an idiom, but I guess it's not well-known enough.

Fixup commit pushed for both issues, including the third "server" :)

Squashed as bug20488_029_squashed, and merged to 0.3.2. Not backporting.

Note: See TracTickets for help on using tickets.