Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2051 closed defect (fixed)

Unit tests test_util_spawn_background_* fail when run from make distcheck

Reported by: sjmurdoch Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by sjmurdoch)

Currently the unit tests test_util_spawn_background_* assume that they are run from the Tor build directory (so as to find test-child). This is not the case when running make distcheck, so the test will fail. The path to test-child can be found through dirname(argv[0])/../test-child, but unit tests don't have access to argv[0]. Therefore one solution is to use autoconf to find the Tor build directory and base the path on this.

Originally reported by Sebastian Hahn.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by Sebastian

Component: - Select a componentTor Client
Status: newneeds_review

Looks good to me and fixes the issue.

comment:2 Changed 9 years ago by sjmurdoch

Description: modified (diff)

Believed fixed in 06eafb3 of git://git.torproject.org/sjm217/tor.git (fix-test-child branch).

comment:3 Changed 9 years ago by Sebastian

Ok, the updated version still looks good to me :)

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged;

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.