Opened 4 years ago

Closed 4 years ago

#20510 closed enhancement (fixed)

Use metrics-lib's getHidserv* methods in Metrics' hidserv module

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When Metrics' hidserv module was written in March 2015, metrics-lib did not support hidserv-* lines in extra-info descriptors, so it had to implement its own parsing code and parse extra-info descriptors a second time.

This has changed in December 2015 with metrics-lib 1.1.0 adding "support for hidden-service statistics in extra-info descriptors".

It's time to replace that custom parsing code in Metrics' hidserv module and use the methods provided by metrics-lib.

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by karsten

Cc: iwakeh added
Status: newneeds_review

Please review my task-20510 branch.

comment:2 Changed 4 years ago by iwakeh

Looks fine.
Please find here some streamlining suggestions toward the common metrics project layout, java 7, and metrics-lib 1.5.0.
(connbidirect left out as it is the onlyy one with tests so far.)

comment:3 Changed 4 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Looks good. Pushed both commits to master. Closing. Thanks!

Note: See TracTickets for help on using tickets.