CollecTor's exitlists module should avoid httpurlconnection

See #20323 (moved):

ExitListDownloader should replace HttpURLConnections. This a little trickier than the other two *Downloader tasks because the annotation needs to be prepended.

changed milestone to %CollecTor 1.2.0

added component::metrics/collector metrics-help milestone::CollecTor 1.2.0 owner::iwakeh parent::8799 priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

See also #20543 (moved).

Trac:
Milestone: N/A to CollecTor 1.2.0

Adding myself to cc to make trac mail updates.

Trac:
Cc: N/A to iwakeh

Trac:
Status: new to accepted
Owner: N/A to iwakeh

Simply switching to file copy would mean a major change here as the current download approach reads the data to memory for verifying and after that writes to file(s). A toy example of an http-server that accepts connections, but never writes the response code yielded the stack-trace provided in #22602 (moved). The easiest remedy is setting a read-timeout. (A quick inspection of the code that gets used when using Files.copy indicates that a timeout seems to be set there, too.)

Open points:

• the current read timeout is arbitrarily set to 5000ms. How to find the best value?
• Should a connect timeout be set, too? There is no bug report that indicates necessity for this timeout type.

Please review this change.

Trac:
Status: accepted to needs_review

Patch looks good and is now merged to master! I believe 5000ms is as good as a first guess as any other value. We'll find out if it's too low or high over time, and we'll find out if we should have set a connect timeout as well. I'd say let's start with this, it's better than what we did before. Closing as fixed. Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #20543 (moved)

mentioned in issue #21443 (moved)

mentioned in issue #22602 (moved)