Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20520 closed defect (fixed)

stem test_installs_all_files fails with *.swo file

Reported by: chelseakomlo Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I run make test-stem (which is also a sub-task of make test-full, I see the below error.

I submitted a basic fix for this here: git@github.com:chelseakomlo/stem.git, branch swo_fix, and a refactor which makes the code more extensible if we need to exclude other file formats.

Running tests...

  util.conf...                                         success (0.00s)
  util.connection...                                   success (0.00s)
  util.proc...                                         success (0.00s)
  util.system...                                       success (1.04s)
  installation...                                      failed (0.35s)
test_installing_stem                                         [SUCCESS]
test_installs_all_files                                      [FAILURE]

======================================================================
FAIL: test_installs_all_files
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/chelseakomlo/Documents/development/open/stem/test/integ/installation.py", line 96, in test_installs_all_files
    self.fail("The following files were expected to be in our installation but weren't. Maybe our setup.py needs to be updated?\n\n%s" % '\n'.join(mi$sing))
AssertionError: The following files were expected to be in our installation but weren't. Maybe our setup.py needs to be updated?

stem/.prereq.py.swo

----------------------------------------------------------------------
Ran 2 tests in 0.346s

Let me know if there are any recommended changes for this!

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by cypherpunks

Component: Core TorCore Tor/Stem
Owner: set to atagar

comment:2 Changed 3 years ago by chelseakomlo

Status: newneeds_review

comment:3 Changed 3 years ago by atagar

Resolution: fixed
Status: needs_reviewclosed

Thanks Chelsea, great catch! Fix pushed.

comment:4 Changed 3 years ago by cypherpunks

Regarding the question in the commit message for this ticket see http://vimdoc.sourceforge.net/htmldoc/recover.html#swap-file, especially the part that says

The name of the swap file is normally the same as the file you are editing,
with the extension ".swp".
...
- If this file already exists (e.g., when you are recovering from a crash) a
  warning is given and another extension is used, ".swo", ".swn", etc.

comment:5 Changed 3 years ago by atagar

Ah! Thanks for the clarification. :)

comment:6 in reply to:  3 Changed 3 years ago by chelseakomlo

Replying to atagar:

Thanks Chelsea, great catch! Fix pushed.

I'm glad it was useful :) Thanks for the quick fix!

Note: See TracTickets for help on using tickets.