Opened 3 years ago

Closed 3 years ago

#20523 closed enhancement (fixed)

Use metrics-lib for parsing descriptors

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Metrics/ExoneraTor Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We're using metrics-lib for downloading descriptors from CollecTor, but we're still using our own parsing code. Let's avoid duplicating code by using what metrics-lib provides.

Also update to Java 7 and metrics-lib 1.5.0.

Branch follows in a moment.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by karsten

Cc: iwakeh added
Status: newneeds_review

Please review my task-20523 branch.

comment:2 Changed 3 years ago by iwakeh

Looks fine, nice to see all those lines replaced by standard-metrics-lib parsing!

Please find a commit on top of that here straightening out the project structure toward metrics project standards.
And, please test thoroughly, if this still works as expected.

comment:3 Changed 3 years ago by karsten

Status: needs_reviewneeds_revision

Thanks for looking at the patch and for making those build changes.

Would you mind making some more changes to that build.xml? (I'm terrible at finding the correct Ant commands for all those things.)

  • src/main/webapp/logging.properties needs to be included in exonerator.war as WEB-INF/classes/logging.properties (currently missing).
  • src/main/webapp/css/* need to be included in exonerator.war as css/* (currently in root).
  • src/main/webapp/images/* need to be included in exonerator.war as images/* (currently in root).
  • config can be omitted from exonerator.war (currently in WEB-INF/classes/)
  • src/main/resources/db/exonerator.sql can be omitted from exonerator.war (currently in WEB-INF/classes/db/)
  • Is the etc property actually used?
  • Can you include ${libs}/gson-2.2.4.jar in the classpath (was already missing before).

Thanks!

comment:4 in reply to:  3 ; Changed 3 years ago by iwakeh

Replying to karsten:

Thanks for looking at the patch and for making those build changes.

Would you mind making some more changes to that build.xml? (I'm terrible at finding the correct Ant commands for all those things.)

Sure, please find the amended branch.

Thanks for checking this thoroughly!

comment:5 in reply to:  4 Changed 3 years ago by karsten

Status: needs_revisionneeds_review

Thanks for those fixes. The only thing I'm still missing is logging.properties. Mind taking a look at the last commit in my updated task-20523 branch?

comment:6 Changed 3 years ago by iwakeh

Oh, I forgot to commit the move of logging.properties into resources.
amended here

I'd rather keep logging configuration in 'resources' than in 'webapp'.

comment:7 Changed 3 years ago by iwakeh

This is the correct link.

comment:8 Changed 3 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged to master. Thanks! Closing.

Note: See TracTickets for help on using tickets.