Implement `rend_service_is_ephemeral()`

Checking if directory is NULL is not so readable. Replace such checks with rend_service_is_ephemeral().

changed milestone to %Tor: 0.3.0.x-final

added component::core tor/tor milestone::Tor: 0.3.0.x-final points::0.1 priority::low resolution::implemented reviewer::dgoulet severity::normal status::closed tor-hs type::enhancement labels

Trac:
Status: new to needs_review

The patch looks good but I can't apply it on git master... One issue that I can't figure out. Can you retry on current git master? Sorry about that.

Trac:
Reviewer: N/A to dgoulet
Points: N/A to 0.1
Priority: Medium to Low
Status: needs_review to needs_revision
Keywords: N/A deleted, tor-hs added
Milestone: N/A to Tor: 0.3.0.x-final

Trac:
0001-Added-rend_service_is_ephemeral-and-made-related-cod.patch

rebased against current master

Trac:
Status: needs_revision to needs_review

Thanks twim!

I've signed off commit in: bug20526_030_01

Trac:
Status: needs_review to merge_ready

This needs a changes file; could one of you please add one?

  o Refactoring (onion services):
    - Introduce rend_service_is_ephemeral() that tells if given onion
      service is ephemeral. Replace unclear NULL-checkings for service
      directory with this function. Closes ticket 20526.

Does this look plausible?

yup! adding that and merging. Thanks!

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 48m

mentioned in issue #20853 (moved)

moved to tpo/core/tor#20526 (closed)