Opened 7 months ago

Closed 7 months ago

#20526 closed enhancement (implemented)

Implement `rend_service_is_ephemeral()`

Reported by: twim Owned by:
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

Checking if directory is NULL is not so readable. Replace such checks with rend_service_is_ephemeral().

Child Tickets

Attachments (1)

0001-Added-rend_service_is_ephemeral-and-made-related-cod.patch (2.9 KB) - added by twim 7 months ago.
rebased against current master

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 months ago by twim

  • Status changed from new to needs_review

comment:2 Changed 7 months ago by dgoulet

  • Keywords tor-hs added
  • Milestone set to Tor: 0.3.0.x-final
  • Points set to 0.1
  • Priority changed from Medium to Low
  • Reviewer set to dgoulet
  • Status changed from needs_review to needs_revision

The patch looks good but I can't apply it on git master... One issue that I can't figure out. Can you retry on current git master? Sorry about that.

Changed 7 months ago by twim

rebased against current master

comment:3 Changed 7 months ago by twim

  • Status changed from needs_revision to needs_review

comment:4 Changed 7 months ago by dgoulet

  • Status changed from needs_review to merge_ready

Thanks twim!

I've signed off commit in: bug20526_030_01

comment:5 Changed 7 months ago by nickm

This needs a changes file; could one of you please add one?

comment:6 Changed 7 months ago by twim

  o Refactoring (onion services):
    - Introduce rend_service_is_ephemeral() that tells if given onion
      service is ephemeral. Replace unclear NULL-checkings for service
      directory with this function. Closes ticket 20526.

Does this look plausible?

Last edited 7 months ago by twim (previous) (diff)

comment:7 Changed 7 months ago by nickm

  • Resolution set to implemented
  • Status changed from merge_ready to closed

yup! adding that and merging. Thanks!

Note: See TracTickets for help on using tickets.