Opened 3 years ago

Closed 3 years ago

#20527 closed defect (implemented)

Fix some unescaped printings of rendservice directories

Reported by: twim Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description


Child Tickets

Attachments (1)

0001-Do-escape-rendservice-directories-before-printing-th.patch (4.8 KB) - added by twim 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by twim

Status: newneeds_review

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.0.x-final

comment:3 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready

lgtm; I made an extra fixup commit on top to fix minor things where we kept the print format \"%s\" which would ultimately add again the double quotes.

I also signed off the commit and slightly changed the name :).

See bug20527_030_01

comment:4 in reply to:  3 Changed 3 years ago by twim

Replying to dgoulet:

lgtm; I made an extra fixup commit on top to fix minor things where we kept the print format \"%s\" which would ultimately add again the double quotes.

AFAIK, escaped() already makes strings quoted:

 Allocate and return a new string representing the contents of s,
 surrounded by quotes and using standard C escapes.

Am I wrong?

comment:5 Changed 3 years ago by dgoulet

Right it does, I actually removed \"%s\" in favor of %s in I think 3 callsites. Is that ok?

comment:6 Changed 3 years ago by twim

Oops, was looking at this upside down. ;) It's okay now.

comment:7 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

okay, squashed and merged . thanks!

Note: See TracTickets for help on using tickets.