Opened 3 years ago

Closed 3 years ago

#20529 closed defect (fixed)

Check the directory for each rend service, not just the last one

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.2-alpha
Severity: Normal Keywords: tor-hs
Cc: Actual Points: 0.2
Parent ID: #20484 Points: 0.2
Reviewer: Sponsor:

Description

In #13942, we added code to check that a configured hidden service's directory had the correct permissions.

But the fix committed in 85bfad1 in tor-0.2.6.2-alpha only checked the last hidden service configured.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by teor

Actual Points: 0.2
Status: newneeds_review

The last commit on my branch bug20484_029 has a fix for this issue.
(It uses the refactoring in that branch.)

comment:2 Changed 3 years ago by nickm

(It's no longer the last commit; it's 1747f28861e1f5ce8fc5c8cb3eaad0c7f2297dc9)

comment:3 Changed 3 years ago by nickm

Status: needs_reviewmerge_ready

that commit looks good to me. We can take it with the rest of that branch when we merge it

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.