Changes between Initial Version and Version 1 of Ticket #20546, comment 7


Ignore:
Timestamp:
Dec 21, 2016, 8:23:27 PM (2 years ago)
Author:
iwakeh
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20546, comment 7

    initial v1  
    33I didn't look deeply, e.i. think my way through the code, yet, but it's a very clean style.
    44Your test coverage is also up to 93% for CleanUtils, great.  (I didn't reply to your question
    5 in comment:6, because trac doesn't mail anything for edited comments.  So I didn't see the question.)
     5in comment:5, because trac doesn't mail anything for edited comments.  So I didn't see the question.)
    66
    77Maybe, try to think up some tests that trigger exceptions and also to find out, what happens when unexpected input is given, like `null` or empty Strings or a file disappeared before being erased or never existed etc.