Opened 3 years ago

Closed 3 years ago

#20551 closed defect (fixed)

Implicit conversion warnings with openssl 1.1 on 32-bit platforms

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 029-backport 028-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

13:25:05 src/common/tortls.c:1650:30: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
13:25:05   result->last_write_count = BIO_number_written(bio);
13:25:05                            ~ ^~~~~~~~~~~~~~~~~~~~~~~
13:25:05 src/common/tortls.c:1651:29: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
13:25:05   result->last_read_count = BIO_number_read(bio);
13:25:05                           ~ ^~~~~~~~~~~~~~~~~~~~
13:25:05 src/common/tortls.c:2266:7: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
13:25:05   r = BIO_number_read(SSL_get_rbio(tls->ssl));
13:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13:25:05 src/common/tortls.c:2287:7: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
13:25:05   w = BIO_number_written(wbio);
13:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~
13:25:05 4 errors generated.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Description: modified (diff)
Keywords: 029-backport 028-backport added
Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final
Summary: Implicit conversion warnings with openssl 1.1Implicit conversion warnings with openssl 1.1 on 32-bit platforms

Branch bug20551_028 has the fix here. I'm applying it to master. How far back to backport?

comment:2 Changed 3 years ago by nickm

Status: newneeds_review

comment:3 Changed 3 years ago by nickm

This appears to be breaking jenkins builds everyplace now.

comment:4 Changed 3 years ago by yawning

IMO backport to 028/029, since that's when we started supporting OpenSSL 1.1.

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.2.8.x-final
Resolution: fixed
Status: needs_reviewclosed

Your recommendation plus the broken jenkins is enough for me. Merging. :)

Note: See TracTickets for help on using tickets.