Changes between Initial Version and Version 1 of Ticket #20551


Ignore:
Timestamp:
Nov 3, 2016, 1:37:34 PM (3 years ago)
Author:
nickm
Comment:

Branch bug20551_028 has the fix here. I'm applying it to master. How far back to backport?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20551

    • Property Keywords 029-backport 028-backport added
    • Property Milestone changed from Tor: 0.2.8.x-final to Tor: 0.2.9.x-final
    • Property Summary changed from Implicit conversion warnings with openssl 1.1 to Implicit conversion warnings with openssl 1.1 on 32-bit platforms
  • Ticket #20551 – Description

    initial v1  
     1{{{
     213:25:05 src/common/tortls.c:1650:30: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
     313:25:05   result->last_write_count = BIO_number_written(bio);
     413:25:05                            ~ ^~~~~~~~~~~~~~~~~~~~~~~
     513:25:05 src/common/tortls.c:1651:29: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
     613:25:05   result->last_read_count = BIO_number_read(bio);
     713:25:05                           ~ ^~~~~~~~~~~~~~~~~~~~
     813:25:05 src/common/tortls.c:2266:7: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
     913:25:05   r = BIO_number_read(SSL_get_rbio(tls->ssl));
     1013:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     1113:25:05 src/common/tortls.c:2287:7: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned long' [-Werror,-Wshorten-64-to-32]
     1213:25:05   w = BIO_number_written(wbio);
     1313:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~
     1413:25:05 4 errors generated.
     15}}}