Opened 3 years ago

Closed 3 years ago

#20556 closed defect (fixed)

pt-PT Tor Browser bundles are diguised pt-BR bundles

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Normal Keywords: tbb-usability, TorBrowserTeam201612
Cc: isabela, phoul, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

isabela reported that our pt-PT bundles are actually pt-BR ones and we should fix that as this confuses users.

Child Tickets

Change History (18)

comment:1 Changed 3 years ago by gk

Owner: changed from erinn to tbb-team
Status: newassigned

comment:2 Changed 3 years ago by gk

Status: assignedneeds_information

phoul said we use the pt-BR strings for our stuff (Tortbutton) etc. So, I am curious what is actually wrong with our bundles. Are the Mozilla strings wrong as well? I somehow doubt that as we download the pt-PT bundle for Portugese. So, it seems we mix them and want to have pure pt-BR bundles instead? Or pure pt-PT ones?

comment:3 Changed 3 years ago by i353368

pt-br is the most common variant, it should use pt-br in instance of pt-pt because the number of speaker is a determinant of fingerprint, and doesn't have much difference of both.

My preference is to use just pt-br for don't segment user in a lot of fingerprint.

comment:4 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611 added

Might be worth fixing for 6.5 and getting it tested before that.

Last edited 3 years ago by gk (previous) (diff)

comment:5 Changed 3 years ago by isabela

Those are language codes for two different languages: pt_PT is Portuguese from Portugal which is different from Portuguese from Brazil (pt_BR).

We were using translation in PT from Brazil and distributing it with the wrong language code (the one for Portugal). This can be quite frustrating for users who are expecting one type of translation.

So yes, the correct language code for the language we support (translations coming from transifex) should be pt_BR.

comment:6 Changed 3 years ago by gk

Cc: boklm added
Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: needs_informationneeds_review

It seems just doing s/pt-PT/pt-BR/ in our versions* files might already be enough (I'll open a separate ticket for the website changes). This is done in my bug_20556 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20556&id=4e45d469698ae10d06a665bd105bfb0ea1ed2f97) which is up for review.

comment:7 Changed 3 years ago by boklm

The patch looks good to me.

Regarding the update, the users of the pt-PT bundle will be updated to the english bundle as the pt-PT one won't exist in the new version. I'm wondering if we should do something to update them to the pt-PT one instead.

comment:8 in reply to:  7 ; Changed 3 years ago by gk

Replying to boklm:

The patch looks good to me.

Regarding the update, the users of the pt-PT bundle will be updated to the english bundle as the pt-PT one won't exist in the new version. I'm wondering if we should do something to update them to the pt-PT one instead.

Yes, they should probably get the full pt-BR .mar file. I guess there is just some server-side tweaking necessary? If so, could you take care of it?

comment:9 Changed 3 years ago by boklm

comment:10 in reply to:  8 Changed 3 years ago by boklm

Replying to gk:

Yes, they should probably get the full pt-BR .mar file. I guess there is just some server-side tweaking necessary? If so, could you take care of it?

The branch bug_20556_update_responses has a patch for this:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_20556_update_responses

After renaming the pt-PT mar files to pt-BR and running make update_responses-alpha with this patch, I get an .htaccess file containing new lines such as:

RewriteRule ^Linux_x86-gcc3/[^/]+/pt-PT 6.5a3-linux32-pt-BR.xml [last]

comment:11 in reply to:  9 Changed 3 years ago by gk

Replying to boklm:

I see that in torbutton and tor-launcher, we have both pt and pt-BR containing differents translations:
https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt
https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt-BR
https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/locale/pt
https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/locale/pt-BR

Were we using the pt one before, and this change makes us use the pt-BR one now?

Not sure. I guess what happens is the following: we ship pt-PT bundles now but looking at the above links there is no so locale. Rather, we only have pt and pt-BR. The code is presumably falling back to pt (I have not checked that) which turns out to be pt-BR which we import during translation updates. I guess the same is happening with Tor Launcher. Now, the interesting part is what is going to happen if we switch to pt-BR officially? Then we probably use the pt-BR branch as you mentioned even though we only update the pt one every time. I guess we need to update the locale import scripts as well...

Last edited 3 years ago by gk (previous) (diff)

comment:12 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611 added; TorBrowserTeam201611R removed
Status: needs_reviewnew

Not ready for 6.5a4, alas. It needs more investigation and probably a patch to our translations import script(s). Keeping it on our November radar, though, as we want to have it in 6.5a5.

comment:13 Changed 3 years ago by gk

Status: newneeds_information

Phoul, isabela: Could anyone of you confirm that the translated strings we have in

https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt-BR and
https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/locale/pt-BR

are really the ones we want (and that they are up-to-date)? If so, switching to pt-BR should be not problematic. If not, and the real strings are in pt, can we just get them into pt-BR instead and make sure translators are using that one from now on?

comment:14 Changed 3 years ago by isabela

Browsing the content on the links above, they are pt-BR translations but they are not complete - some strings are still in English. So I don't really know if they are updated with what is on Transifex (Transifex has pt-BR as 100% complete).

ps: I can't load the PT translations on transifex for some reason

comment:15 Changed 3 years ago by phoul

comment:16 in reply to:  15 Changed 3 years ago by gk

Status: needs_informationassigned

Replying to phoul:

It appears you have the right translations for pt-BR, however they are not all current. For example:

https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt-BR/aboutTor.dtd

&

https://gitweb.torproject.org/translation.git/tree/pt_BR/aboutTor.dtd?h=abouttor-homepage_completed

do not match.

That's probably due to us not importing pt-BR translations during language string updates. Thus, once we adjusted our import script this should be fine.

Last edited 3 years ago by gk (previous) (diff)

comment:17 Changed 3 years ago by gk

Keywords: TorBrowserTeam201612 added; TorBrowserTeam201611 removed

Moving tickets to December.

comment:18 Changed 3 years ago by gk

Resolution: fixed
Status: assignedclosed

Okay, we are done here with two patches to tor-browser-bundle.git: commits 06fe66a1d2d366078a63147447389e397cfbf505 and c3e365d6eb07ea07a4187380aebe2c6015a50346 and one to torbutton updating our translations import script: e2fc692ca82ee04eff6d8ffd2313116638d2f6a4. I updated Torbutton master with the latest translations, too. #20901 is for the website changes.

Note: See TracTickets for help on using tickets.