rend_config_services ignores failures in rend_add_service

Tor used to warn but continue on some hidden service misconfigurations. Instead, the fix I am adding #20484 (moved) will consider these misconfigurations a config error, and terminate tor.

I think it's better to stop with an error, than potentially reveal sensitive information due to a misconfiguration (or, far more likely, just ignore hidden services the user has misconfigured).

Bugfix on commit 915c743 in #6411 (moved) in tor-0.2.7.1-alpha

changed milestone to %Tor: 0.3.0.x-final

added actualpoints::0.3 component::core tor/tor milestone::Tor: 0.3.0.x-final points::0.1 priority::medium resolution::fixed review-group-12 severity::normal status::closed tor-hs type::defect version::tor 0.2.7.1-alpha labels

and fixes on 03d6a3171 in 0.2.6.3-alpha, 60a0ae198 in 0.2.1.5-alpha.

Trac:
Parent: N/A to #20484 (moved)
Actualpoints: N/A to 0.1
Keywords: N/A deleted, tor-hs added

This is fixed in #20484 (moved) in my bug20484_029: 428ee66 Stop ignoring misconfigured hidden services

428ee66 is now part of bug20484_030_v2

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.3.0.x-final
Status: new to needs_review

Trac:
Keywords: N/A deleted, review-group-12 added

My branch bug20599_030_v2 on github fixes this issue.

It passes all the standard checks, plus those in: https://trac.torproject.org/projects/tor/ticket/20638#comment:8

It fails as expected on the following config, which would previously have been ignored:

src/or/tor HiddenServiceDir /tmp/tor.$$.anon HiddenServicePort 80 DataDirectory /tmp/tor.$$ SocksPort 0 PidFile /tmp/tor.pid ControlPort 12345 HiddenServiceDir /tmp/tor.$$.anon HiddenServicePort 80

Trac:
Actualpoints: 0.1 to 0.3
Parent: #20484 (moved) to N/A

I like this branch! It basically addresses almost all of my comments in #20638 (moved)!

The patch looks good to me.

Trac:
Status: needs_review to merge_ready

(The fixup 5f63f2d in bug20638_029_v2 in #20638 (moved) has already been applied to this branch. That might cause a minor merge issue once both branches have been merged. We want to end up with the code containing no duplicate comment, and a call to rend_service_is_ephemeral().)

I changed a commit message in #20638 (moved), the corresponding change is in bug20599_030_v3.

Having merged the branch from #20638 (moved), I've cherry-picked the remaining commits from this branch onto a new branch, "bug20599_030_v4". I've read them and they seem fine fine to me.

Teor, can you confirm whether this branch is still okay to you (and I didn't miss anything)? If so, I'm happy to merge it into master.

Yes, that looks like exactly what I wanted - and I am glad we left it for 0.3.0. Let's get it merged.

Merged it is!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 2h 24m of time spent

mentioned in issue #20638 (moved)

mentioned in issue #20860 (moved)

moved to tpo/core/tor#20559 (closed)