Opened 2 years ago

Closed 2 years ago

#20566 closed enhancement (fixed)

example page should have links for the mirror it is on

Reported by: iwakeh Owned by:
Priority: Medium Milestone: Onionoo 3.1-1.0.0
Component: Metrics/Onionoo Version:
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

See cthultu. The links are not clickable; it would be nice to have a real link with the example to run on the mirror it is on (better even open a new window). The display of the non-clickable url can be left on onionoo tpo.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by iwakeh

Status: newneeds_review

Please, see my branch with a suggestion in the top commit; the commit before that tweaks build.xml.

comment:2 Changed 2 years ago by karsten

Merged the first commit to master, edited the second commit in my task-20566 branch. Let me know if those edits are okay, and I'll squash and push to master. Thanks!

comment:3 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

That change of omitting the host part of the url looks fine!
Ready for merge.

comment:4 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Perfect! Squashed and pushed to master. Closing. Thanks!

Note: See TracTickets for help on using tickets.