Opened 3 years ago

Closed 3 years ago

#20583 closed defect (fixed)

The downloads.json file created by the update_responses script is not reproducible

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R, tbb-gitian
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Running make update_responses twice will generate a downloads.json with the same content, but in a different order.

Child Tickets

Attachments (1)

0001-Bug-20583-make-the-downloads.json-file-reproducible.patch (903 bytes) - added by boklm 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: newneeds_review

comment:2 Changed 3 years ago by boklm

I attached a patch to fix this.

comment:3 Changed 3 years ago by mcs

I think the changes are okay, given my limited Perl knowledge. I assume canonical is what ensures the order is consistent.

comment:4 Changed 3 years ago by boklm

Yes, this is what canonical is doing: https://metacpan.org/pod/JSON#canonical
We are also changing from the functional to the object-oriented interface as this is the only way to set the canonical option.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master, maint-6.0 and hardened-builds (commits a442c22cd7771bd717558b0d7d41ee478f7a190f 5d9099aa9406a0084aa89df85fe165488b151e60 and 4df28e4afbd833126d4f9c3409795c6890b31b74).

Note: See TracTickets for help on using tickets.