Opened 3 years ago

Closed 3 years ago

#20587 closed defect (fixed)

Limit next_attempt_overflow to TIME_MAX, not INT_MAX

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: CoreTorTeam201611
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: Sponsor:

Description

Found while examining #20499 code

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Actual Points: 0
Points: 0
Status: acceptedneeds_review

There's a commit for this in my branch 20499_part1_029. Adding teor to cc since the bug was in his 35bbf2e4a4e8ccb

comment:3 Changed 3 years ago by teor

Keywords: CoreTorTeam201611 added
Status: needs_reviewneeds_revision
Version: Tor: 0.2.8.1-alpha

Looks good to me.

I am concerned we didn't have a unit test that would pick this up. We should probably add one to test_dir_download_status_schedule().

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed
Note: See TracTickets for help on using tickets.