Opened 3 years ago

Closed 3 years ago

#20591 closed defect (fixed)

Ensure relays don't make multiple connections during bootstrap

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: 029-proposed, CoreTorTeam201611
Cc: Actual Points: 0.1
Parent ID: #20499 Points: 0.1
Reviewer: Sponsor:

Description

In update_consensus_networkstatus_downloads, relays use ClientBootstrapConsensusMaxInProgressTries as the maximum number of in-progress attempts, even though this value should only be used for clients.

(However, relays do not deliberately launch multiple attempts, so the impact of this bug should be minimal. Still, we should fix this to defend against bugs like #20499.)

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by teor

Actual Points: 0.1
Status: newneeds_review

Please see my github branch bug20591.
It is a one-line fix that defends against bugs similar to #20499.

comment:2 Changed 3 years ago by teor

Except you probably want bug20591_029, so it can be merged to 0.2.9.

comment:3 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm ; merging this.

Note: See TracTickets for help on using tickets.