Opened 4 years ago

Last modified 2 years ago

#20594 new enhancement

hs: Make HSDir produce HS statistics for prop224

Reported by: dgoulet Owned by:
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, tor-spec, prop224-extra, statistics, privcount-maybe, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: SponsorQ-can


You can find in hs_cache.c this line which indicates the callsite where we should gather the "uniqueness of .onion".

/* XXX: Update HS statistics. We should have specific stats for v3. */

Now here is the tricky part. HSDir can't learn a .onion address anymore with prop224 so counting the unique blinded key we see could do the trick but might give us a different value from what we have now. Blinded keys will change every ~24h which is the timeframe where every relay currently reset the HS stats so it could be fine as a representation of a unique .onion.

This will require a dir-spec change as we'll have to add something like this because we can't use the v2 stats (hidserv-dir-onions-seen):

    "hidserv-dir-blindedkey-seen" SP num SP key=val SP key=val ... NL

Last thing, @cypherpunks, we know that you don't like that so when commenting here, please tell us why you don't want it with some useful argumentation. Thanks ;).

Child Tickets

Change History (11)

comment:1 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Extra fun item to have but doesn't depend on the minimal viable feature we want to deliver before.

comment:2 Changed 3 years ago by dgoulet

Keywords: prop224-extra added

This keyword indicate that it is a nice extra feature to have for prop224 but not needed for the minimal viable implementation.

comment:3 Changed 3 years ago by dgoulet

Priority: MediumVery High

Prioritize prop224 tickets for 031 milestone. They are all "Enhancement".

comment:4 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

We think it's not realistic for 031.

comment:5 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.2.x-finalTor: unspecified

We can't make those for 032 so for now they go in Unspecified.

comment:6 Changed 3 years ago by nickm

Keywords: statistics privcount-maybe added

comment:7 Changed 3 years ago by nickm

Sponsor: SponsorR-mustSponsorQ-can

comment:8 Changed 3 years ago by teor

Milestone: Tor: unspecifiedTor: 0.3.4.x-final
Priority: Very HighHigh

We expect this to be implemented using PrivCount in 0.3.3 or 0.3.4.

comment:9 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:10 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:11 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.