Opened 3 years ago

Closed 3 years ago

#20612 closed defect (fixed)

update_responses: Error opening application.ini

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since #19528, during the make update_responses step we are extracting a mar file to read its application.ini file. In some cases, when the extracted mar file is for OSX, we get an error saying that the application.ini file could not be opened.

Child Tickets

Attachments (1)

0001-Bug-20612-fix-path-to-application.ini.patch (1.1 KB) - added by boklm 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201611R added
Status: newneeds_review

We have some code checking the two possible paths, and putting the correct path in the variable $appfile. However we don't use this variable when opening the file.

I attached a patch fixing that.

comment:2 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master (418f5d66e9d064530b1a4d7ce5a96b03980ea14f) and hardened-builds (7b0f893e548f7dc0090d22ccfa58e06940adc61c), thanks.

Note: See TracTickets for help on using tickets.