Add link to Tor Browser manual to about:tor

We can do this for the US English locale now, and for other locales as they are produced.

added TorBrowserTeam201611R component::applications/tor browser owner::tbb-team parent::11698 priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
Keywords: N/A deleted, TorBrowserTeam201611 added

Here's a patch that shows links to the Tor Browser User Manual in about:tor and also in the Help Menu, only for the US English locale.

https://github.com/arthuredelstein/torbutton/commit/20614

In the future, we can also think about bundling the user manual HTML pages inside Tor Browser and then allowing users to view it offline (#20639 (moved)).

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201611 deleted, TorBrowserTeam201611R added

It seems we would not need

#middle a.tips {
  display: block;
  margin-top: 1.6em;
}

anymore with your patch? Or you forgot class="tips"?

s/Makes sure the tem/Makes sure the item/

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201611R deleted, TorBrowserTeam201611 added
Cc: N/A to gk, mcs, brade

Replying to gk:

[...]

Thanks, Georg. I have fixed both things. I also simplified the patch in torbutton.js somewhat.

https://github.com/arthuredelstein/torbutton/commit/20614+1

Trac:
Status: needs_revision to needs_review

The patch looks okay to Kathy and me. Our only comment is to consider placing the "Tor Browser User Manual" link on about:tor after the "Tips on Staying Anonymous" one. The text under "What Next?" is more related to the "Tips" link more than it is to the manual.

Replying to mcs:

The patch looks okay to Kathy and me. Our only comment is to consider placing the "Tor Browser User Manual" link on about:tor after the "Tips on Staying Anonymous" one. The text under "What Next?" is more related to the "Tips" link more than it is to the manual.

A good idea -- thanks. Here's the new version: https://github.com/arthuredelstein/torbutton/commit/20614+2

Looks good to me.

This is commit 24e2f3aa02b40274e20e27aa568c076bd74f7b2f on master now. Note, though, that the URL is not properly redirecting to the manual I'd like to see: the one for Linux users. Currently I get redirected to the Windows one. I think this is a blocker for getting this shipped in the stable series and I opened #20739 (moved) to fix that.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed
Keywords: TorBrowserTeam201611 deleted, TorBrowserTeam201611R added

closed

mentioned in issue #20639 (moved)

mentioned in issue #20739 (moved)

mentioned in issue tpo/web/manual-trac#20739 (closed)

moved to tpo/applications/tor-browser#20614 (closed)

mentioned in issue tpo/applications/tor-browser#20639 (closed)