Opened 3 years ago

Closed 3 years ago

#20614 closed defect (fixed)

Add link to Tor Browser manual to about:tor

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: gk, mcs, brade Actual Points:
Parent ID: #11698 Points:
Reviewer: Sponsor:

Description

We can do this for the US English locale now, and for other locales as they are produced.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611 added

comment:2 Changed 3 years ago by arthuredelstein

Here's a patch that shows links to the Tor Browser User Manual in about:tor and also in the Help Menu, only for the US English locale.

https://github.com/arthuredelstein/torbutton/commit/20614

In the future, we can also think about bundling the user manual HTML pages inside Tor Browser and then allowing users to view it offline (#20639).

comment:3 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: newneeds_review

comment:4 Changed 3 years ago by gk

It seems we would not need

#middle a.tips {
  display: block;
  margin-top: 1.6em;
}

anymore with your patch? Or you forgot class="tips"?

s/Makes sure the tem/Makes sure the item/

comment:5 Changed 3 years ago by gk

Cc: gk mcs brade added
Keywords: TorBrowserTeam201611 added; TorBrowserTeam201611R removed
Status: needs_reviewneeds_revision

comment:6 in reply to:  4 Changed 3 years ago by arthuredelstein

Status: needs_revisionneeds_review

Replying to gk:

[...]

Thanks, Georg. I have fixed both things. I also simplified the patch in torbutton.js somewhat.

https://github.com/arthuredelstein/torbutton/commit/20614+1

comment:7 Changed 3 years ago by mcs

The patch looks okay to Kathy and me. Our only comment is to consider placing the "Tor Browser User Manual" link on about:tor after the "Tips on Staying Anonymous" one. The text under "What Next?" is more related to the "Tips" link more than it is to the manual.

comment:8 in reply to:  7 Changed 3 years ago by arthuredelstein

Replying to mcs:

The patch looks okay to Kathy and me. Our only comment is to consider placing the "Tor Browser User Manual" link on about:tor after the "Tips on Staying Anonymous" one. The text under "What Next?" is more related to the "Tips" link more than it is to the manual.

A good idea -- thanks. Here's the new version:
https://github.com/arthuredelstein/torbutton/commit/20614+2

comment:9 Changed 3 years ago by mcs

Looks good to me.

comment:10 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Resolution: fixed
Status: needs_reviewclosed

This is commit 24e2f3aa02b40274e20e27aa568c076bd74f7b2f on master now. Note, though, that the URL is not properly redirecting to the manual I'd like to see: the one for Linux users. Currently I get redirected to the Windows one. I think this is a blocker for getting this shipped in the stable series and I opened #20739 to fix that.

Note: See TracTickets for help on using tickets.