Opened 2 years ago

Closed 23 months ago

#20620 closed defect (fixed)

Unit test purpose_needs_anonymity_returns_true_by_default possible bug

Reported by: s7r Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.0-alpha-dev
Severity: Normal Keywords: unit tests
Cc: chelseakomlo Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

dir/purpose_needs_anonymity_returns_true_by_default: Nov 09 17:25:37.223 [warn] purpose_needs_anonymity: Bug: Called with dir_purpose=0, router_purpose=0 (on Tor 0.3.0.0-alpha-dev d564187deedb9b85)
OK

Since the test returns OK, also printing the line "Bug: [...]" seams confusing.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by teor

Cc: chelseakomlo added
Points: 0.1

Yes, we fix BUG logs in our unit tests.

Maybe we should just remove the function call that's causing the BUG message, or pass it sane values.

This was likely introduced in #20077.

comment:2 Changed 23 months ago by nickm

Resolution: fixed
Status: newclosed

Resolved in 1d45438ef03564b7af2f3a5b4b0e3ff7a9570a97

Note: See TracTickets for help on using tickets.