Opened 3 years ago

Closed 3 years ago

#20626 closed task (fixed)

Update slider and settings tests following the changes from #20264 and #19417

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: TorBrowserTeam201611
Cc: tbb-team, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We need to update the slider and settings tests to take into account the changes from #20264, as well as #19417 on the alpha/nightly channel.

The slider tests need to be adapted to expect different values depending on the Tor Browser version being tested (similar to what we do in the settings tests).

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by arthuredelstein

Cc: arthuredelstein added

comment:2 Changed 3 years ago by boklm

Resolution: fixed
Status: newclosed

The slider_settings tests should now pass on 6.0, 6.5 and nightly versions of Tor Browser.

  • the slider_settings tests have been refactored in a similar way to what was done in torbutton in commit e59f6df84dcfde500f41eefb608dd878a7fc9d6b.
  • the slider_settings_3 test is now disabled, except on Tor Browser 6.0.* versions
  • javascript.options.asmjs is now removed from the slider settings tests
  • an option to add specific settings for 6.0.* versions has been added (but is not needed for now)
Note: See TracTickets for help on using tickets.