Create 64bit Tor Browser for Windows

Mozilla's move to 64bit versions of Firefox for Windows has reached a sufficiently stable state that we can start working on 64bit Tor Browser builds for Windows. This is the parent ticket for all pieces involved.

added TorBrowserTeam201711R component::applications/tor browser owner::tbb-team priority::very high resolution::fixed severity::normal sponsor::4 status::closed tbb-rbm type::defect labels

#9820 (closed) and #7956 (moved) might be worth taking into account as well.

Trac:
Sponsor: N/A to Sponsor4

Adding to our September 2017 tickets.

Trac:
Keywords: N/A deleted, TorBrowserTeam201709 added

Moving over to rbm

Trac:
Keywords: tbb-gitian deleted, tbb-rbm added

Items for October 2017

Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201710 added

I did two builds on two computers with make testbuild-windows-x86_64 from branch boklm/bug_20636_v9 and got the same result, so the build seems to be reproducible.

Currently the filename for a 32bit build is torbrowser-install-7.5a7_en-US.exe. I am not sure what the filename for a 64bit build should be.

Maybe torbrowser-install-win64-7.5a7_en-US.exe?

Replying to boklm:

Currently the filename for a 32bit build is torbrowser-install-7.5a7_en-US.exe. I am not sure what the filename for a 64bit build should be.

Maybe torbrowser-install-win64-7.5a7_en-US.exe?

Sounds good to me.

Moving tickets over to November.

Trac:
Keywords: TorBrowserTeam201710 deleted, TorBrowserTeam201711 added

Changing prio to reflect sponsor deadline

Trac:
Priority: High to Very High

Seems we are good here apart from adapting the Makefile to add a new win64 target?

The branch bug_20636_v12 in my git repo contains 7 others patches needed for the Windows 64 build: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/log/?h=bug_20636_v12

Bug 23229: build firefox for Windows 64 https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=4f71f0121be989e80a74cc7f0d476407bf7fc329

Bug 20636: don't build fteproxy for Windows 64 for now https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=5341706993dfa6ee3b2c8b674e003eeb9e09c1c0

Bug 20636: fix projects/fonts for Windows 64 https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=d0a79f2f2422cfac5155a7f455136e295b50ef95

Bug 20636: fix tor-browser bundle step for Windows 64 https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=5a89431f10be74e1f08cdd804d24999ffd899426

Bug 20636: add Makefile rules for Windows 64 builds https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=fa215970fa0bd34454999ea5a92fe565f80dac7f

Bug 20636: add Windows 64 to projects/release/config https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=c00ea668caa435a6e7aa56fefc0470102df2fcbf

Bug 20636: fix Windows 64 expert bundle filename https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=d37b7a0e0de0057a7a44ae36ac6f10a849299e2a

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201711 deleted, TorBrowserTeam201711R added

Those look good to me, thanks. I merged them to master as commit 4f71f0121be989e80a74cc7f0d476407bf7fc329 commit 5341706993dfa6ee3b2c8b674e003eeb9e09c1c0 commit d0a79f2f2422cfac5155a7f455136e295b50ef95 commit 5a89431f10be74e1f08cdd804d24999ffd899426 commit fa215970fa0bd34454999ea5a92fe565f80dac7f commit c00ea668caa435a6e7aa56fefc0470102df2fcbf commit d37b7a0e0de0057a7a44ae36ac6f10a849299e2a

boklm: Could you open a follow-up ticket for the FTE build please?

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Status: reopened to closed
Resolution: N/A to fixed

I created #24195 (moved) for the fteproxy and obfsproxy part.

I created #24196 (moved) for updating 64bit users to the Windows 64 version.

I added a new patch to bug_20636_v12, to remove fte from the bridges configuration: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v12&id=3c517c1a36a4e9f1251679fc4c129569a874be76

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Status: reopened to needs_review

This is commit 3c517c1a36a4e9f1251679fc4c129569a874be76 on master now, thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #23561 (moved)

moved to tpo/applications/tor-browser#20636 (closed)