Opened 3 years ago

Closed 3 years ago

#20649 closed defect (fixed)

Atlas display for missing GeoIP info could be improved

Reported by: teor Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When atlas can't find a GeoIP entry, it displays "null" for the AS number and name, and https://atlas.torproject.org/img/cc/.png for the image (which does not exist).

It would be better to use some sort of placeholder.

An example of a relay with this issue, as of 2016-11-13:
https://atlas.torproject.org/#details/8FDE6EC5BBB9C275A276D45C3CC93A4A305048FA

Child Tickets

Attachments (1)

mrjamesdoe31033.jpg (80.2 KB) - added by karsten 3 years ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by karsten

Attachment: mrjamesdoe31033.jpg added

comment:1 Changed 3 years ago by karsten

Thanks for the report, and agreed, displaying "null" as AS number and name is not exactly user-friendly. The link you gave does not work anymore, but I'm attaching a screenshot of a relay with country flag but without AS number and name. (I couldn't find a relay lacking all three.)


I wonder if we should just hide AS number and name fields when we don't have anything to display, like we're planning with other field names in #12692. Also see #18989 for the broken image file which we should discuss and fix on that ticket.

comment:2 Changed 3 years ago by RaBe

Owner: changed from irl to RaBe
Status: newassigned

comment:3 Changed 3 years ago by RaBe

Owner: changed from RaBe to irl

For consistency I replaced "null" with "Not defined." instead of hiding the fields completely:

https://github.com/RaphaelBergmann/atlas/commit/1e8256064b94955cb255bf409bbecd0351bf3aa4

comment:4 Changed 3 years ago by RaBe

Status: assignedneeds_review

comment:5 Changed 3 years ago by irl

Status: needs_reviewneeds_revision

RaBe: do you think we can say "unknown" as opposed to "Not defined"? This is not something that is defined by the Tor relay, but instead something which is looked up. It's not a property of the bridge/relay but a property of the AS it is in.

comment:6 Changed 3 years ago by RaBe

Status: needs_revisionneeds_review

comment:7 Changed 3 years ago by irl

Resolution: fixed
Status: needs_reviewclosed

Had to rebase but merged, thanks.

Note: See TracTickets for help on using tickets.