Opened 12 months ago

Closed 9 months ago

#20656 closed enhancement (fixed)

prop224: Tell protover about relay and hsdir support

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: #20657 Points: 0.2
Reviewer: Sponsor: SponsorR-must

Description (last modified by dgoulet)

For relay support in #17241 (parent ticket), we'll need to add version 4 to protover HSIntro so client/service can know which relay they can pick for introduction and version 2 to HSDir.

Child Tickets

Change History (8)

comment:1 Changed 11 months ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:2 Changed 10 months ago by dgoulet

Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final
Parent ID: #17241#20657
Status: assignedaccepted

Moving this to 031 as it only affects client/service so they can choose correctly which intro to pick for legacy or new version.

Changing parent here so as it will be part of the service implementation work.

comment:3 Changed 9 months ago by dgoulet

Milestone: Tor: 0.3.1.x-finalTor: 0.3.0.x-final
Status: acceptedmerge_ready

Ok badly triage!! My fault. I'm also merging #20571 (about HSDir) in this ticket because the patch is so trivial.

Tor patch: ticket20656_030_01
Spec patch: ticket20656_01

comment:4 Changed 9 months ago by dgoulet

Description: modified (diff)
Summary: prop224: Tell protover about relay intro cells supportprop224: Tell protover about relay and hsdir support

comment:5 Changed 9 months ago by nickm

The tor patch looks okay.

For the spec patch, I'd like to see it say what exactly it means by "supports HS protocol v2 as of proposal 224". Like, what cells or what datatypes, in what formats.

comment:6 Changed 9 months ago by nickm

Status: merge_readyneeds_revision

(I've taken the tor part of this patch, but not the spec part yet.)

comment:7 Changed 9 months ago by dgoulet

Status: needs_revisionneeds_review

See ticket20656_01 top commit. Would something like that be more appropriate?

comment:8 Changed 9 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

sounds good. When we merge prop224 into rend-spec, or when we replace rend-spec with it, we should mention these protocol numbers there too.

Note: See TracTickets for help on using tickets.