Opened 2 years ago

Closed 2 years ago

#20668 closed enhancement (implemented)

make test-sources comply to checkstyle

Reported by: iwakeh Owned by: iwakeh
Priority: Medium Milestone: Onionoo 3.1-1.0.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This branch already the build file changes.

Now I'm going to take a look at the 199 complaints.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by iwakeh

Owner: changed from metrics-team to iwakeh
Status: newassigned

comment:2 Changed 2 years ago by iwakeh

Status: assignedneeds_review

Please review the changes and the commit before that, which adapted the build file.

comment:3 Changed 2 years ago by karsten

Looks great, thanks for putting the effort into that!

I made one tiny change by reducing the maximum line length to 80 instead of 81 (from previously 100). Should we adapt that in the other code bases, too?

Oh, and we should mention that change in the header of that file. I can do that.

comment:4 in reply to:  3 ; Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Replying to karsten:

Looks great, thanks for putting the effort into that!

I made one tiny change by reducing the maximum line length to 80 instead of 81 (from previously 100).

For some reason I thought lines should be strictly less than the given number, but 80 is what was intended.

Should we adapt that in the other code bases, too?

I think, you changed that for CollecTor. And, the others don't have (many) tests ;-) Adapt them when it's their turn.

Oh, and we should mention that change in the header of that file. I can do that.

Great, thanks!

Ready for merge.

comment:5 in reply to:  4 ; Changed 2 years ago by karsten

Replying to iwakeh:

Replying to karsten:

Should we adapt that in the other code bases, too?

I think, you changed that for CollecTor. And, the others don't have (many) tests ;-) Adapt them when it's their turn.

Oh, I meant changing max line width from 100 to 80, not including test sources in the checks task. :)

comment:6 in reply to:  5 Changed 2 years ago by iwakeh

Replying to karsten:

...

Oh, I meant changing max line width from 100 to 80, not including test sources in the checks task. :)

Oh, that I considered as given :-)

I'll add this to task #20596 as 'unify all checkstyle rules across Metrics' projects'.

comment:7 Changed 2 years ago by karsten

Status: merge_readyneeds_information

Hmm, what remains to be done here? I think I merged these changes two days ago here. Does that mean we can close this ticket?

comment:8 Changed 2 years ago by iwakeh

Resolution: implemented
Status: needs_informationclosed

True, all is committed.
Thanks!

Closing.

Note: See TracTickets for help on using tickets.