Opened 3 years ago

Last modified 2 years ago

#20671 new defect

Refactor stream cipher API

Reported by: chelseakomlo Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactoring, tor-crypto, api, technical-debt
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

It would be useful to have a symmetric API for stream cipher functionality.

Specifically, functions should have similar signatures, consistent success/error retvals, etc.

As mentioned in #20148, crypto_cipher_new(), crypto_cipher_new_with_iv(), and crypto_cipher_new_with_bits() are prime targets.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by dgoulet

Keywords: crypto added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.???

Would be really nice to have uint8_t * instead of char * but we should be careful as it _might_ have implications on other part of the code.

I'll move that to unknown milestone as YES if we can make it for 030 but not required.

comment:2 Changed 3 years ago by isis

Points: 2

Setting points to 2, since (assuming use of cochinelle, but I'm not sure if this warrants that) this has moderate time requirements.

comment:3 Changed 3 years ago by chelseakomlo

#20717 is a partial fix for this.

comment:4 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:6 Changed 2 years ago by dgoulet

Keywords: tor-crypto added; crypto removed

Unify "crypto" keyword with "tor-crypto".

comment:7 Changed 2 years ago by nickm

Keywords: api technical-debt added
Note: See TracTickets for help on using tickets.