Opened 3 years ago

Last modified 23 months ago

#20672 new defect

Refactor hashing API

Reported by: chelseakomlo Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactoring, tor-crypto, technical-debt api
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

It would be useful for the hashing API in crypto.c to have consistent success/error retvals.

For example, some functions return 1 on error, when instead these should return negative values for errors. See crypto_digest256 for example.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by dgoulet

Keywords: crypto added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.???

Same as in #20671, let's try to use uint8_t * instead of char * if possible.

comment:2 Changed 3 years ago by isis

Points: 2

Setting points to 2, since (assuming use of cochinelle, but I'm not sure if this warrants that) this has moderate time requirements.

comment:3 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by dgoulet

Keywords: tor-crypto added; crypto removed

Unify "crypto" keyword with "tor-crypto".

comment:6 Changed 23 months ago by nickm

Keywords: technical-debt api added
Note: See TracTickets for help on using tickets.