Remove Onionoo's lock file

[karsten]

Onionoo still creates a lock file and fails to start if such a file is present. But the main reason for that file was to avoid concurrent runs triggered by hourly cronjobs. This wouldn't happen anymore, because Onionoo uses its own scheduler to start runs. The only possible issue we're preventing is that the operator runs another Onionoo process in parallel. But CollecTor doesn't use a lock file, either. Is it time to remove Onionoo's lock file? Removing the lock file would make the start script somewhat simpler.

[iwakeh]

I'm all for removing the lock file.

Which start script are you referring to?

[karsten]

Great, I'll remove it from the code, unless you comment here in the next 30 minutes saying you'll do it. :)

Ah, by start script I meant the @reboot crontab line which weasel just turned into a little script on the server. Here it is:

#!/bin/bash

set -e

if [ "$(id -u -n)" != "onionoo" ]; then
  echo >&2 "This script should be run as onionoo."
  exit 1
fi

cd /srv/onionoo.torproject.org/onionoo/
java -Xmx4g -DLOGBASE=/srv/onionoo.torproject.org/onionoo/ -jar dist/onionoo-3.1.1.jar &
disown

[karsten]

Replying to karsten:

Great, I'll remove it from the code, unless you comment here in the next 30 minutes saying you'll do it. :)

Please review the last commit in ​my task-20681 branch.

[iwakeh]

All fine, ready for merge.
Another ticket for the upcoming release.

[karsten]

Thanks for looking, merged! Closing.