Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20704 closed defect (fixed)

The check for code signing in the mar files always fails

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The check for code signing in the mar files, added in #20217, is failing, even when the mar files contain code signing.

The reason is that we include TorBrowser.app in the path we are checking, which is not present in the mar files.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201611R added
Status: newneeds_review

comment:2 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied as commit 234b76caf9c9743a43fcd1ff08f6f180ee981b20. FWIW: it occurred to me the other day that we need to make an exception for the rule established with #20217 once: when we make the updates for 6.0.X -> 6.5 as the former does not have .mar files signed yet. (But that should be easily doable, though)

comment:3 Changed 3 years ago by boklm

Ah, indeed. When preparing the first 6.5 stable release, we'll need to temporarily remove the CHECK_CODESIGNATURE_EXISTS=1 from the dmg2mars makefile rule.

Note: See TracTickets for help on using tickets.