Opened 3 years ago

Closed 3 years ago

#20706 closed task (fixed)

The dmg2mar script contains TorBrowser strings hardcoded

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: tbb-team Actual Points:
Parent ID: #19817 Points:
Reviewer: Sponsor:

Description

We should add an option to make it possible to use the same dmg2mar script for Tor Messenger too.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by boklm

Keywords: TorBrowserTeam201611R added
Status: newneeds_review

The branch bug_20706 has a patch for this:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_20706

I checked that with those changes, the creation of mar files from dmg files is still working on Tor Browser 6.5a4.

And on Tor Messenger, I was able to generate updated mar files by running:

TOR_APPNAME_BUNDLE_OSX=TorMessenger TOR_APPNAME_MARFILE=tor-messenger /path/to/dmg2mar

comment:2 Changed 3 years ago by boklm

Cc: tbb-team added

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master as commit 27e05dc5e3257afd2dbd11d83317001eee70b5f5. Thanks!

Note: See TracTickets for help on using tickets.