Opened 19 months ago

Closed 19 months ago

Last modified 5 months ago

#20707 closed defect (fixed)

Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-usability, TorBrowserTeam201611R, tbb-no-uplift
Cc: arthuredelstein, buschfeuer@…, cactusjack Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have reports that in non-en-US builds the preferences tab is not opening anymore with an XML parsing error:

"XML-Verarbeitungsfehler: Nicht definierte Entität
Adresse: about:preferences
Zeile Nr. 653, Spalte 7: ------^"

Something like XML processing error: Undefined entity adress: about:preferences row 653 column 7.

https://blog.torproject.org/blog/tor-browser-65a4-released#comment-219453 and
https://blog.torproject.org/blog/tor-browser-65a4-hardened-released#comment-219407.

This is very likely due to #20244.

Child Tickets

Change History (11)

comment:1 Changed 19 months ago by Diapolo

Cc: buschfeuer@… added

comment:2 Changed 19 months ago by arthuredelstein

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: newneeds_review

It seems that, even though torbutton is overlaying these checkbox labels with localized strings, XUL still wants to look up the original labels in tor-browser.git, which exist only in the en-US locale. So the solution seems to be to remove any references to localized strings in tor-browser.git. But we want to keep those references in our original #20244 patches so that Mozilla can uplift and localize them. Therefore I'm proposing this separate follow-up patch that removes the references for Tor Browser only.

https://github.com/arthuredelstein/tor-browser/commit/20707

comment:3 Changed 19 months ago by gk

Cc: cactusjack added

Resolved #20726 as duplicate.

comment:4 Changed 19 months ago by cypherpunks

This issue also prevents me from changing the default search engine.

comment:5 in reply to:  2 ; Changed 19 months ago by mcs

Replying to arthuredelstein:

... Therefore I'm proposing this separate follow-up patch that removes the references for Tor Browser only.

https://github.com/arthuredelstein/tor-browser/commit/20707

r=mcs
I think this is an okay solution, although it looks strange to use hard-coded strings.
Maybe the commit message state that this is a fixup for 20244 instead of using this new ticket number?

comment:6 in reply to:  5 Changed 19 months ago by arthuredelstein

Replying to mcs:

Replying to arthuredelstein:

... Therefore I'm proposing this separate follow-up patch that removes the references for Tor Browser only.

https://github.com/arthuredelstein/tor-browser/commit/20707

r=mcs
I think this is an okay solution, although it looks strange to use hard-coded strings.
Maybe the commit message state that this is a fixup for 20244 instead of using this new ticket number?

The reason I did it this way is that I wanted to keep the original patch separate for possible uplift. The hard-coded strings are merely placeholders that are hidden by the torbutton overlay.

comment:7 Changed 19 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, let's take it for the alpha. Seems to be an okay stopgap solution. This is commit 70b2e4769bc4a7dd877e8ca82403d71561dbeec8 on tor-browser-45.5.0esr-6.5-1.

comment:8 Changed 19 months ago by viktorj

Resolution: fixed
Status: closedreopened

This is not fixed for me in Tor Browser 6.5a5 and 6.5a5-hardened, both with german language pack enabled. I get with both this:

XML-Verarbeitungsfehler: Nicht definierte Entität
Adresse: about:preferences
Zeile Nr. 647, Spalte 7:      <checkbox id="thirdpartyIsolateCB"
------^

comment:9 Changed 19 months ago by viktorj

I noticed that this is indeed fixed in the 45.5.0esr-6.5-1 branch, but the commit was not included in the 6.5a5(-hardened) upload. So feel free to close this ticket again or see this as a reminder to include the fix in the next upload.

BTW, there were also three other commits in the 45.5.0esr-6.5-1 branch which were not included in the 6.5a5(-hardened) upload. I couldn't find any "master" branch or something similar, so I assumed that only the latest branch is relevant for bug fixing, especially since this is a ticket concerning the alpha version.

comment:10 Changed 19 months ago by gk

Resolution: fixed
Status: reopenedclosed

Yes, normally all the changes on tor-browser-45.5.0esr-6.5-1 would have made it into 6.5a5 but dealing with a 0-day exploit is quite non-normal. Thus, in order to minimize the risk for breakage I decided to include only the most important patches into the update which left out the things you mentioned. 6.5a6 getting released next week will contain them.

comment:11 Changed 5 months ago by arthuredelstein

Keywords: tbb-no-uplift added
Note: See TracTickets for help on using tickets.