Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20712 closed enhancement (implemented)

Put out Onionoo 3.1-1.0.0 release

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: Onionoo 3.1-1.0.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This ticket is for putting out the Onionoo 3.1-1.0.0 release, including any improvements to the build process to make that happen.

Child Tickets

Attachments (1)

license.patch (133.4 KB) - added by hiro 2 years ago.
LICENSE for included binaries

Download all attachments as: .zip

Change History (20)

comment:1 Changed 2 years ago by karsten

Please find build improvements in my task-20712 branch and try out this pre-release tarball.

comment:2 Changed 2 years ago by karsten

Status: newneeds_review

comment:3 Changed 2 years ago by iwakeh

The pre-release jar and war are not signed, which is due to the signjar task: At least in my environment it pretended to sign, but the jar and war were not signed. The second to the last commit adds a check to the target.

The last commit makes all work again by demanding that the signed jar/war are created in a new directory. In addition, it adds a simplification for filling the git-revision property.

Please review.

(I will continue to look at the release tar for other issues, just wanted this posted already.
Will also make a note for #20596)

comment:4 Changed 2 years ago by karsten

Both changes look good, merged to my branch. Here's a new pre-release tarball.

comment:5 Changed 2 years ago by hiro

Attaching updates to LICENSE. I have added the corresponding licenses for the libraries that are going to be included in the release, although maybe it only needed to mention the license and point users to the appropriate repositories?

comment:6 Changed 2 years ago by iwakeh

Second pre-release-tar.gz contains unusual paths probably from a symbolic link to the 'lib' folder.
Example:

...
onionoo-3.1-0.9.0-dev//Users/karsten/src/onionoo/lib/hamcrest-core-1.3.jar
onionoo-3.1-0.9.0-dev//Users/karsten/src/onionoo/lib/jetty8-continuation-8.1.16.v20140903.jar
onionoo-3.1-0.9.0-dev//Users/karsten/src/onionoo/lib/jetty8-http-8.1.16.v20140903.jar
onionoo-3.1-0.9.0-dev//Users/karsten/src/onionoo/lib/jetty8-io-8.1.16.v20140903.jar

comment:7 Changed 2 years ago by iwakeh

It seems the war-file doesn't contain any o.t.onionoo classes?

comment:8 Changed 2 years ago by karsten

The LICENSE patch looks good to me. Will merge unless I hear objections by tomorrow morning.

Those two problems with the second pre-release (oops!) should be fixed in my task-20712 branch and in the third pre-release. Please take another look!

comment:9 in reply to:  8 Changed 2 years ago by iwakeh

Replying to karsten:

The LICENSE patch looks good to me. Will merge unless I hear objections by tomorrow morning.

Looks fine, but we also ship checkstyle and cobertura, which have some more libraries that are not yet covered, afaict.

Cf. excerpt from build.xml

 <path id="checkstyle.classpath" >
    <fileset dir="${libs}">
      <include name="checkstyle-6.17-all.jar" />
    </fileset>
  </path>

  <path id="cobertura.classpath">
    <fileset dir="${libs}">
      <include name="descriptor-${descriptorversion}.jar"/>
      <include name="cobertura-2.1.1.jar" />
      <include name="slf4j-api-1.7.7.jar" />
      <include name="commons-lang3-3.3.2.jar" />
      <include name="asm4-5.0.3.jar" />
      <include name="asm4-util-5.0.3.jar" />
      <include name="asm4-tree-5.0.3.jar" />
      <include name="asm4-commons-5.0.3.jar" />
      <include name="asm4-analysis-5.0.3.jar" />
      <include name="oro-2.0.8.jar" />
      <include name="logback-core-1.1.2.jar" />
      <include name="logback-classic-1.1.2.jar" />
    </fileset>
  </path>

Those two problems with the second pre-release (oops!) should be fixed in my task-20712 branch and in the third pre-release. Please take another look!

I will :-)

comment:10 Changed 2 years ago by iwakeh

The link to the pre-release number three is onionoo-3.1-0.9.0-dev-3.tar.gz.

Last edited 2 years ago by iwakeh (previous) (diff)

comment:11 Changed 2 years ago by hiro

We also ship:
asm4
oro
in addition to cobertura. That have minor license differences. License updated.

Last edited 2 years ago by hiro (previous) (diff)

comment:12 Changed 2 years ago by iwakeh

Thanks for the quick additions!

Just checkstyle needs to be added; it's GPL 2.1 checkstyle license.

Should we also mention CC-By 3.0 License for the metrics_checks.xml that we derived from Google's style?

comment:13 Changed 2 years ago by karsten

Quick reminder: tomorrow is the release date! :)

comment:14 Changed 2 years ago by hiro

Sorry, keep missing the notifications on updates from trac. License file now updated. If you think I should I can add Google style license.

comment:15 Changed 2 years ago by iwakeh

If you could add checkstyle (comment:12) and the google-style license that would be fine.

Changed 2 years ago by hiro

Attachment: license.patch added

LICENSE for included binaries

comment:16 Changed 2 years ago by hiro

Hi iwakeh, checkstyle was already included, now I also have added google-style license. Now everything should be there.

comment:17 in reply to:  16 Changed 2 years ago by iwakeh

Replying to hiro:

Hi iwakeh, checkstyle was already included, now I also have added google-style license. Now everything should be there.

Great! Thanks!
Now all is there for the release.

comment:18 Changed 2 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Cool! And now it's released here: https://dist.torproject.org/onionoo/3.1-1.0.0/ . Thanks, everyone! Closing.

comment:19 Changed 2 years ago by iwakeh

... and announced here!

Note: See TracTickets for help on using tickets.