Opened 3 years ago

Closed 3 years ago

#20745 closed defect (fixed)

test_installs_all_data_files fails with vim .swo files

Reported by: chelseakomlo Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I received the following failure:

AssertionError: setup.py doesn't install stem/stem/.prereq.py.swo

It might be useful to have a set of file types to include, rather than exclude, but this is a larger refactor (but something to think about if this error happens with another file type).

Another possible refactor is to extract this list as it is used in several different places (so we have one single list of file types that we exclude). Specifically, we have the same logic in test/integ/installation.py and test/unit/installation.py, for example.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by chelseakomlo

I have a patch for this here: git@github.com:chelseakomlo/stem.git, branch swo_unit

comment:2 Changed 3 years ago by atagar

Resolution: fixed
Status: newclosed

Thanks Chelsea! Fix pushed. It dropped the 'orig' check so I added that back in.

Note: See TracTickets for help on using tickets.